1957314 - Enable native UI Automation on Nightly

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement)

Comment 1

[James Teh [:Jamie] (away returning 14 Apr)]

Attachment: Bug 1957314 part 2: enable native UIA on Nightly.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3c4b8db67cc
enable native UIA on Nightly. r=morgan

Comment 3

[Iulian Moraru]

Backed out for causing crashes on std::_Atomic_integral<unsigned int,4>::fetch_add.
This has affected multiple windows jobs.

• Push with failures

• Failure log example 1

• Failure log example 2

• Backout link

Comment 4

[James Teh [:Jamie] (away returning 14 Apr)]

Attachment: Bug 1957314 part 1: nsAccUtils::GetLiveRegionSetting: Don't assume the accessibility service is running.

Some tests (e.g. Marionette and WPT) can start the accessibility service in a content process without starting it in the parent process.
When this happens, the content process will still send the accessibility tree, events, etc. to the parent process via IPDL, and the parent process will create the RemoteAccessible tree.
However, the accessibility service still isn't running in the parent process unless a client instantiates it.
Previously, nsAccUtils::GetLiveRegionSetting assumed the accessibility service was running without checking.
UIA calls this method when firing certain events, so this was causing a crash.
To fix this, just null check it.
In future, we may wish to consider not firing events if the service isn't running or some other broader solution for this situation, but I don't think it's worth investing in that now, especially as this is only relevant to tests.

I also added an assertion for the presence of the service in nsAccUtils::SetLiveContainerAttributes.
Because this is only used for setting attributes, callers already check that the service exists before calling this, but an assertion should help enforce this.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b55e50bc199
part 1: nsAccUtils::GetLiveRegionSetting: Don't assume the accessibility service is running. r=morgan
https://hg.mozilla.org/integration/autoland/rev/db4236ad6e02
part 2: enable native UIA on Nightly. r=morgan

Comment 6

[Atila Butkovits]

Backed out for causing failures at browser_aria_domain.js.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/b3d99a6bf6be20c854264bdf6e0ff29f78cd91e5

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=db4236ad6e02a270de34fed0ae2db97727b651d0&selectedTaskRun=PSpcFubHRLK4GEFaab8Q-Q.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=502875482&repo=autoland&lineNumber=2421

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2be1662a8bff
part 1: nsAccUtils::GetLiveRegionSetting: Don't assume the accessibility service is running. r=morgan
https://hg.mozilla.org/integration/autoland/rev/e10738fac397
part 2: enable native UIA on Nightly. r=morgan

Comment 8

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/2be1662a8bff
https://hg.mozilla.org/mozilla-central/rev/e10738fac397