Closed
Bug 1957641
Opened 10 months ago
Closed 4 months ago
XULBrowserElement is missing the properties defined in browser-custom-element.js in TypeScript
Categories
(Developer Infrastructure :: Lint and Formatting, task)
Tracking
(firefox146 fixed)
RESOLVED
FIXED
146 Branch
| Tracking | Status | |
|---|---|---|
| firefox146 | --- | fixed |
People
(Reporter: mbeier, Assigned: standard8)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
I noticed that TypeScript doesn't know about XULBrowserElement properties defined browser-custom-element.js. This causes errors when type checking is enabled. Maybe we could look into this.
| Assignee | ||
Comment 1•9 months ago
|
||
Updated•9 months ago
|
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Updated•9 months ago
|
Attachment #9484954 -
Attachment description: Bug 1957641 - Change TypeScript definitions to use MozBrowser from browser-custom-element.mjs rather than a hand-crafted type. r?zombie! → WIP: Bug 1957641 - Change TypeScript definitions to use MozBrowser from browser-custom-element.mjs rather than a hand-crafted type. r?zombie!
Updated•4 months ago
|
Attachment #9484954 -
Attachment description: WIP: Bug 1957641 - Change TypeScript definitions to use MozBrowser from browser-custom-element.mjs rather than a hand-crafted type. r?zombie! → Bug 1957641 - Change TypeScript definitions to use MozBrowser from browser-custom-element.mjs rather than a hand-crafted type. r?zombie!
Pushed by mbanner@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/1961e713f211
https://hg.mozilla.org/integration/autoland/rev/09cb7556850a
Change TypeScript definitions to use MozBrowser from browser-custom-element.mjs rather than a hand-crafted type. r=zombie,tgiles
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
status-firefox146:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 146 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•