1957706 - Puppeteer node based tests should use toolchains rather than installing from npm for each test run

Status: RESOLVED FIXED

(Remote Protocol :: Agent, task, P3)

Description

[Mark Banner (:standard8)]

Currently the Puppeteer tests all install directly from npm for every test run. We should move those across to toolchains, to avoid having to rely on external servers etc -e.g. this failure due to an issue with npmjs.

The toolchains should be built once when package*.json is changed, and then used for each test until the next change.

A previous example of this is bug 1920970.

Comment 1

[Mark Banner (:standard8)]

Note: bug 1957705 now has a patch on which is probably simpler to reference/understand than the other bug I mentioned.

Comment 2

[Julian Descottes [:jdescottes]]

Mark, is this something you could take or should our team do it?

Comment 3

[Mark Banner (:standard8)]

(In reply to Julian Descottes [:jdescottes] from comment #2)

Mark, is this something you could take or should our team do it?

I would prefer your team to take a look, iirc, there was something I was unsure about at the time, and I thought your team might be able to handle it better, but I can't remember what that was now. In any case, I don't really have time for this at the moment.

Comment 4

[Julian Descottes [:jdescottes]]

Thanks let's keep it in our next milestone then!

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1957706 - [remote] Use toolchain for puppeteer node tests (directory)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/24447290ca1d
https://hg.mozilla.org/integration/autoland/rev/a34803330cbb
[remote] Use toolchain for puppeteer node tests (directory) r=releng-reviewers,jcristau

Comment 7

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/a34803330cbb