Open Bug 1957706 Opened 5 months ago Updated 2 months ago

Puppeteer node based tests should use toolchains rather than installing from npm for each test run

Categories

(Remote Protocol :: Agent, task, P3)

Product:
Remote Protocol
Component:
Agent
Type:
task
Points:
3

Tracking

(Not tracked)

People

(Reporter: standard8, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [webdriver:m17])

Currently the Puppeteer tests all install directly from npm for every test run. We should move those across to toolchains, to avoid having to rely on external servers etc -e.g. this failure due to an issue with npmjs.

The toolchains should be built once when package*.json is changed, and then used for each test until the next change.

A previous example of this is bug 1920970.

Summary: Puppeteer node based tests should all use toolchains rather than installing from npm for each test run → Puppeteer node based tests should use toolchains rather than installing from npm for each test run

Note: bug 1957705 now has a patch on which is probably simpler to reference/understand than the other bug I mentioned.

Points: --- → 3
Priority: -- → P3
Whiteboard: [webdriver:m16]
Whiteboard: [webdriver:m16] → [webdriver:m17]

Mark, is this something you could take or should our team do it?

Flags: needinfo?(standard8)

(In reply to Julian Descottes [:jdescottes] from comment #2)

Mark, is this something you could take or should our team do it?

I would prefer your team to take a look, iirc, there was something I was unsure about at the time, and I thought your team might be able to handle it better, but I can't remember what that was now. In any case, I don't really have time for this at the moment.

Flags: needinfo?(standard8)

Thanks let's keep it in our next milestone then!

You need to log in before you can comment on or make changes to this bug.