1957767 - When account is disconnected, cannot log back into profile

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect, P3)

Description

[Sammy Khamis [:skhamis]]

Desktop Nightly 139.0a1

When I changed my password on iOS, this caused my account on desktop to go into "disconnection state". The "Account already in use" modal says i'm already signed in to it via "Original profile", however i'm already on "Original profile" and does not let me sign in. I had to remove account -> sign in to get rid of this.

The fix is most likely _getProfileAssociatedWithAcct(acctEmail) https://searchfox.org/mozilla-central/source/services/fxaccounts/FxAccountsWebChannel.sys.mjs#979 should do an additional check to see if the current account state is disconnected or something similar to ensure the pop up doesn't show up.

Comment 1

[Sammy Khamis [:skhamis]]

Attachment: image.png

Comment 2

[Sammy Khamis [:skhamis]]

Attachment: account_already_in_use_modal

Comment 3

[Sammy Khamis [:skhamis]]

Attachment: Bug 1957767 - Correctly skip current profile when signing in r=markh,jhirsch

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b84513d493ad
Correctly skip current profile when signing in r=markh,jhirsch

Comment 5

[Atila Butkovits]

Backed out for causing failures at test_sync_warning_dialogs.js.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/7d29bb2477c046e379fe634029970d17cc7c7154

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=FYbBM74iRcyYN8UNO2qVGQ.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=d4de6ef7b02d4385a399fb5ef94d4217c53a64d5

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=502869661&repo=autoland&lineNumber=4732
https://treeherder.mozilla.org/logviewer?job_id=502869674&repo=autoland&lineNumber=3914

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8c3d2d29ffa
Correctly skip current profile when signing in r=markh,jhirsch

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f8c3d2d29ffa

Comment 9

[Sammy Khamis [:skhamis]]

Attachment: Bug 1957767 - Correctly skip current profile when signing in r=markh,jhirsch

Original Revision: https://phabricator.services.mozilla.com/D244243

Comment 10

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: User cannot login to disconnected profile
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: 1. Enable profiles, 2. Connect two clients to the same account, 3. Change the password on the account, 3. Try to reconnect the client that got disconnected from the pw change
• Risk associated with taking this patch: low
• Explanation of risk level: small code surface, easy to understand problem
• String changes made/needed: N/A
• Is Android affected?: no

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/322604191f9f