1957847 - Convert more JS holders to use Hold/DropJSObjectsWithKey APIs where appropriate

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Jon Coppeard (:jonco)]

Following on from bug 1953167, we can convert more JS holders to use the new Hold/DropJSObjectsWithKey APIs, where approriate. This should be more efficient for holders that are always added to the map and call HoldJSObjects during initialization.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Promise and CallbackTimeoutHandler might be good candidates. They are not WrapperCached, so the preserving wrapper won't trigger the other holdJSObjects call.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1957847 - Part 1: Add assertions to catch misuse of Add/DropJSHolders APIs r?smaug

This adds static assertions that the Add/DropJSHoldersWithKey APIs are not used
for wrapper cached objects, and runtime assertions that these APIs are not used
for objects that were previously used with the original Add/DropJSHolders APIs.
Unfortunately it's not possible to check the inverse of the latter case.

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1957847 - Part 2: Use Add/DropJSHoldersWithKey APIs for Promise r?smaug

Comment 4

[Jon Coppeard (:jonco)]

Attachment: Bug 1957847 - Part 3: Use Add/DropJSHoldersWithKey APIs for CallbackTimeoutHandler r?smaug

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82cd5111cd88
Part 1: Add assertions to catch misuse of Add/DropJSHolders APIs r=smaug
https://hg.mozilla.org/integration/autoland/rev/c94929a03423
Part 2: Use Add/DropJSHoldersWithKey APIs for Promise r=smaug
https://hg.mozilla.org/integration/autoland/rev/4ee747773a72
Part 3: Use Add/DropJSHoldersWithKey APIs for CallbackTimeoutHandler r=smaug

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/82cd5111cd88
https://hg.mozilla.org/mozilla-central/rev/c94929a03423
https://hg.mozilla.org/mozilla-central/rev/4ee747773a72