1957892 - 26.06% glterrain (Linux) regression on Tue March 25 2025

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Treeherder Bug Filer]

Perfherder has detected a talos performance regression from push 5597515065c79e8d34f20c916740f5a14e49ba8c. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
26%	glterrain	linux1804-64-shippable-qr	e10s fission stylo webrender	2.20 -> 2.77

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 44517

The following documentation link provides more information about this command.

For more information on performance sheriffing please see our FAQ.

If you have any questions, please do not hesitate to reach out to [e-mail].

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1954446

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Looks like we fails again to create dmabuf backend for WebGL. Will look at it.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

There's the related log.

215 matches
[task 2025-04-08T09:53:19.153Z] 09:53:19     INFO -  PID 3900 | [Parent 3900: CanvasRenderer]: D/Dmabuf DMABufDevice::IsDMABufWebGLEnabled: UseDMABuf 1 sUseWebGLDmabufBackend 1 UseDMABufWebGL 1
[task 2025-04-08T09:53:19.153Z] 09:53:19     INFO -  PID 3900 | [Parent 3900: CanvasRenderer]: D/Dmabuf DMABufDevice::IsDMABufWebGLEnabled: UseDMABuf 1 sUseWebGLDmabufBackend 1 UseDMABufWebGL 1
[task 2025-04-08T09:53:19.162Z] 09:53:19     INFO -  PID 3900 | [Parent 3900: CanvasRenderer]: D/Dmabuf [7f219dc248a0]: DMABufSurfaceRGBA::Create() UID 1 size 1 x 1 format 0x34325241 modifiers 0
[task 2025-04-08T09:53:19.163Z] 09:53:19     INFO -  PID 3900 | [Parent 3900: CanvasRenderer]: D/Dmabuf [7f219dc248a0]:     Creating without modifiers
[task 2025-04-08T09:53:19.163Z] 09:53:19     INFO -  PID 3900 | [Parent 3900: CanvasRenderer]: D/Dmabuf [7f219dc248a0]:     Success
[task 2025-04-08T09:53:19.163Z] 09:53:19     INFO -  PID 3900 | [Parent 3900: CanvasRenderer]: D/Dmabuf [7f219dc248a0]: DMABufSurfaceRGBA::CreateTexture() UID 1 plane 0
[task 2025-04-08T09:53:19.164Z] 09:53:19     INFO -  PID 3900 | [Parent 3900: CanvasRenderer]: D/Dmabuf [7f219dc248a0]:   UseDmaBufGL() failed
[task 2025-04-08T09:53:19.165Z] 09:53:19     INFO -  PID 3900 | [Parent 3900: CanvasRenderer]: D/Dmabuf [7f219dc248a0]: DMABufSurfaceRGBA::ReleaseTextures() UID 1
[task 2025-04-08T09:53:19.165Z] 09:53:19     INFO -  PID 3900 | [Parent 3900: CanvasRenderer]: D/Dmabuf [7f219dc248a0]: DMABufSurface::ReleaseDMABuf() UID 1
[task 2025-04-08T09:53:19.165Z] 09:53:19     INFO -  PID 3900 | [Parent 3900: CanvasRenderer]: D/Dmabuf SurfaceFactory_DMABUF::CanCreateSurface() failed to create surface.
[task 2025-04-08T09:53:19.166Z] 09:53:19     INFO -  PID 3900 | [Parent 3900: CanvasRenderer]: D/Dmabuf SurfaceFactory_DMABUF::Create() failed, fallback to SW buffers.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

[GFX1-]: DMABufSurface::UseDmaBufExportExtension(): old GL version!

Looks like we failed due to old GL version on try.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1957892 [Linux] Check GL version to create dmabuf via. export extension only r?emilio

Comment 6

[Greg Hess]

:stransky this bug has no severity set, could you please triage to help understand impact on Fx138.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de5e6d00efa8
[Linux] Check GL version to create dmabuf via. export extension only r=emilio

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/de5e6d00efa8

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:stransky, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox138 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9477713 [details]
Bug 1957892 [Linux] Check GL version to create dmabuf via. export extension only r?emilio

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Slow WebGL rendering.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Revert back previous state, don't check GL version for WebGL, only EGLImage export extension.
• String changes made/needed:
• Is Android affected?: Yes

Comment 11

[Dianna Smith [:diannaS]]

Comment on attachment 9477713 [details]
Bug 1957892 [Linux] Check GL version to create dmabuf via. export extension only r?emilio

Approved for 138.0b7

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/4abb1f3e53eb

Comment 13

[Andra Esanu (needinfo me)]

(In reply to Pulsebot from comment #7)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de5e6d00efa8
[Linux] Check GL version to create dmabuf via. export extension only r=emilio

Perfherder has detected a talos performance change from push de5e6d00efa8f6e52f6a5a228480fe2ed746de65.

If you have any questions, please reach out to a performance sheriff. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
20%	glterrain	linux1804-64-shippable-qr	e10s fission stylo webrender	2.74 -> 2.19

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a performance sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 44713

The following documentation link provides more information about this command.