1957934 - Define alias for typedef classes using the IDL typedef name

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), enhancement)

Description

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

typedef (Foo or Bar) Baz should be able to be called Baz instead of FooOrBar.

Comment 1

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 1957934 - Part 1: Rename ReadableStreamController to ReadableStreamControllerBase r=#webidl

The name ReadableStreamController collides with the same-named Web IDL union type.

Comment 2

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 1957934 - Part 2: Rename FormDataValue to IPCFormDataValue r=#webidl

This name collides with the same-named Web IDL union type.

Comment 3

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 1957934 - Part 3: Rename UniFFIScaffoldingValue to OwningUniFFIScaffoldingValue r=#webidl

Because the autogenerated union name will be OwningUniFFIScaffoldingValue for the owning variant of the union.

Comment 4

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 1957934 - Part 4: Autogenerate IDL union aliases r=#webidl

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7ffb59ab130
Part 1: Rename ReadableStreamController to ReadableStreamControllerBase r=webidl,smaug
https://hg.mozilla.org/integration/autoland/rev/bd6bd66c98f9
Part 3: Rename UniFFIScaffoldingValue to OwningUniFFIScaffoldingValue r=webidl,smaug

Comment 6

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 1957934 - Part 5: Fix uniffi generator r=#webidl,gregp

Followup for D244387.

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/d7ffb59ab130
https://hg.mozilla.org/mozilla-central/rev/bd6bd66c98f9

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2087cf3321e
Part 5: Fix uniffi generator r=gregp

Comment 9

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/d2087cf3321e

Comment 10

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 1957934 - Part 4: Autogenerate headers with IDL identifiers r=edgar

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90524890ff3a
Part 2: Rename FormDataValue to IPCFormDataValue r=webidl,smaug
https://hg.mozilla.org/integration/autoland/rev/7d18bd30f164
Part 4: Autogenerate headers with IDL identifiers r=edgar,media-playback-reviewers,padenot

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/90524890ff3a
https://hg.mozilla.org/mozilla-central/rev/7d18bd30f164

Comment 13

[Sandor Molnar[:smolnar]]

Backed out for causing win build bustages

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/14ccbadd53d062181184bc10c49cac801ed44456

Push with failures

Failure log -> ERROR - /builds/worker/workspace/obj-build/dist/include/mozilla/dom/BindingUtils.h(2447,37): error: base class has incomplete type

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The build failure only affects 32-bit shippable builds on Windows.

Comment 15

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 1957934 - Part 5: Add missing header inclusion

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/e6503503a896
Part 2: Rename FormDataValue to IPCFormDataValue r=webidl,smaug
https://hg.mozilla.org/mozilla-central/rev/b0ed789c871b
Part 5: Add missing header inclusion