1958289 - Crash in [@ geckoservo::glue::Servo_AnimationValue_GetColor]

Status: RESOLVED DUPLICATE of bug 1919415

(Core :: CSS Transitions and Animations, defect)

Description

[Ryan VanderMeulen (PTO, back July 27)]

Crash report: https://crash-stats.mozilla.org/report/index/847af1d6-b7e3-45b6-b07d-7ef090250402

Reason:

EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames:

0  xul.dll  geckoservo::glue::Servo_AnimationValue_GetColor(enum2$<style::properties::gen...  servo/ports/geckolib/glue.rs:760
1  xul.dll  mozilla::layers::CompositorAnimationStorage::StoreAnimatedValue(nsCSSProperty...  gfx/layers/CompositorAnimationStorage.cpp:242
2  xul.dll  mozilla::layers::CompositorAnimationStorage::SampleAnimations::<lambda_0>::op...  gfx/layers/CompositorAnimationStorage.cpp:403
3  xul.dll  mozilla::layers::APZCTreeManager::CallWithMapLock(mozilla::layers::Compositor...  gfx/layers/apz/src/APZCTreeManager.h:636
3  xul.dll  mozilla::layers::APZSampler::CallWithMapLock(mozilla::layers::CompositorAnima...  gfx/layers/apz/public/APZSampler.h:115
3  xul.dll  mozilla::layers::CompositorAnimationStorage::SampleAnimations(mozilla::layers...  gfx/layers/CompositorAnimationStorage.cpp:414
4  xul.dll  mozilla::layers::OMTASampler::SampleAnimations(mozilla::TimeStamp const&, moz...  gfx/layers/wr/OMTASampler.cpp:128
4  xul.dll  mozilla::layers::OMTASampler::Sample(mozilla::wr::TransactionWrapper&)  gfx/layers/wr/OMTASampler.cpp:115
4  xul.dll  mozilla::layers::OMTASampler::Sample(mozilla::wr::WrWindowId const&, mozilla:...  gfx/layers/wr/OMTASampler.cpp:68
4  xul.dll  omta_sample(mozilla::wr::WrWindowId, mozilla::wr::Transaction*)  gfx/layers/wr/OMTASampler.cpp:245

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:TYLin, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Hi Boris, could you assign Severity for this bug?

Comment 3

[Boris Chiou [:boris]]

Looks similar to Bug 1946570. Mark S3.

Comment 4

[Mayank Bansal]

Bug 1997436 has a real-world testcase that crashes with the same signature.

Comment 5

[Daniel Holbert [:dholbert]]

(In reply to Mayank Bansal from comment #4)

Bug 1997436 has a real-world testcase that crashes with the same signature.

That bug was fixed by bug 1919415, so this probably was too (hard to tell for sure without a testcase).

We've only had one crash with this signature since bug 1919415 landed on Nightly 148, and the crash was on (unpatched) release 146 (presumably for someone like bug 1919415's reporter who had manually preffed on scroll-driven animations).

Given the crash signature matching and the backtrace looking similar, I think we're safe to assume that this was the same. Let's dupe.