1958293 - Crash in [@ mozilla::css::SheetLoadData::VerifySheetReadyToParse]

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

28 crashes from 12 installs of Firefox 137.0 and no reports for v136. Are these crashes related to the reported userChrome.css changes in v137?

Crash report: https://crash-stats.mozilla.org/report/index/5b74d692-add3-48ed-97ab-d87ce0250403

Reason:

EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames:

0  xul.dll  mozilla::css::SheetLoadData::VerifySheetReadyToParse(nsresult, nsTSubstring<c...  layout/style/Loader.cpp:770
0  xul.dll  mozilla::css::StreamLoader::OnStopRequest(nsIRequest*, nsresult)  layout/style/StreamLoader.cpp:161
1  xul.dll  nsSyncLoadService::PushSyncStreamToListener(already_AddRefed<nsIInputStream>,...  dom/base/nsSyncLoadService.cpp:360
2  xul.dll  mozilla::css::Loader::LoadSheetSyncInternal(mozilla::css::SheetLoadData&, moz...  layout/style/Loader.cpp:1209
2  xul.dll  mozilla::css::Loader::LoadSheet(mozilla::css::SheetLoadData&, mozilla::css::L...  layout/style/Loader.cpp:1305
3  xul.dll  mozilla::css::Loader::InternalLoadNonDocumentSheet(nsIURI*, mozilla::css::Sty...  layout/style/Loader.cpp:2187
4  xul.dll  mozilla::css::Loader::LoadSheetSync(nsIURI*, mozilla::css::SheetParsingMode, ...  layout/style/Loader.cpp:2114
5  xul.dll  nsStyleSheetService::LoadAndRegisterSheetInternal(nsIURI*, unsigned int)  layout/base/nsStyleSheetService.cpp:159
6  xul.dll  nsStyleSheetService::LoadAndRegisterSheet(nsIURI*, unsigned int)  layout/base/nsStyleSheetService.cpp:111
7  xul.dll  mozilla::dom::ContentChild::RecvLoadAndRegisterSheet(nsIURI*, unsigned int co...  dom/ipc/ContentChild.cpp:2872

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Are these crashes related to the reported userChrome.css changes in v137?

Do you know the answer?

Comment 2

[Emilio Cobos Álvarez [:emilio]]

No, this seems like a regression from bug 1948887.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1958293 - Null-check referrer URI in CSS Loader warning. r=#style

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99277fb83bb8
Null-check referrer URI in CSS Loader warning. r=jwatt

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/99277fb83bb8

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9476952 [details]
Bug 1958293 - Null-check referrer URI in CSS Loader warning. r=#style

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Null check
• String changes made/needed: none
• Is Android affected?: Yes

Comment 7

[Dianna Smith [:diannaS]]

Comment on attachment 9476952 [details]
Bug 1958293 - Null-check referrer URI in CSS Loader warning. r=#style

Approved for 138.0b4

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/8b7894e391f8

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9476952 [details]
Bug 1958293 - Null-check referrer URI in CSS Loader warning. r=#style

Approved as a ridealong for 137.0.1 that ships this week.

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/f73500eca786