1958325 - Move TimedPromise to remote/shared/Sync.sys.mjs

Status: RESOLVED FIXED

(Remote Protocol :: Agent, task, P3)

Description

[Julian Descottes [:jdescottes]]

The TimedPromise helper is used in a shared module and will be used in a BiDi module starting with Bug 1947402.

We should move it to remote/shared/Sync.sys.mjs

It doesn't depend on any other marionette module, so moving it should be straightforward.

Comment 1

[Martin Pitt]

Julian, I submitted this to https://phabricator.services.mozilla.com/D247041 . I did not run the unit tests locally yet, I hope that happens in CI in phabricator?

Comment 2

[Martin Pitt]

Attachment: Bug 1958325 - Move TimedPromise to remote/shared/Sync.sys.mjs

We will use it in the BiDi module in the next commit.

Drop the unused TimedPromise import from telemetry test altogether.

Comment 3

[Julian Descottes [:jdescottes]]

(In reply to Martin Pitt from comment #1)

Julian, I submitted this to https://phabricator.services.mozilla.com/D247041 . I did not run the unit tests locally yet, I hope that happens in CI in phabricator?

It runs a very small subset of quick tests & linting, but otherwise the CI either has to be started by the developer (https://firefox-source-docs.mozilla.org/tools/try/index.html) or worst case scenario it would be triggered automatically when landing the patch on our integration branch (autoland). I can push the patch to CI

Comment 4

[Martin Pitt]

Updated the patch according to review, and ran the bidi tests.

Notes to my future self: I tried

./mach web-platform-tests --include /webdriver --headless

which fails with

ERROR: Couldn't find geckodriver binary required to run wdspec tests, consider `ac_add_options --enable-geckodriver` in your build configuration

Fair enough, but when I add that to ./mozconfig, a mach build fails with

mozbuild.configure.options.InvalidOptionError: --enable-geckodriver is not available in this configuration

What works is to download current https://github.com/mozilla/geckodriver/releases and run

./mach web-platform-tests --include /webdriver/tests/bidi --headless --webdriver-binary /tmp/geckodriver

I also tried --processes 5 but it doesn't make a difference.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Hi Martin. The error message isn't ideal and we should only print it when a full build is configured but not for an artifact build that you have. Mind filing a bug for that?

Otherwise please see the following document in how to build geckodriver so that it is available for running the wdspec tests:
https://firefox-source-docs.mozilla.org/testing/geckodriver/Building.html

I wonder why --webdriver-binary doesn't work - or which kind of failure do you get?

Comment 6

[Martin Pitt]

@whimboo: --webdriver-binary does work. I have successfully run the tests, and that's probably easier/faster than rebuilding it. AFAIUI, geckodriver is fairly independent anyway. I did look at https://firefox-source-docs.mozilla.org/testing/geckodriver/Building.html , but I figure this happens because my inititial setup was not for a full build, but with downloading the pre-built cached binaries or so? Anyway, it's all good!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/446fca777d18
Move TimedPromise to remote/shared/Sync.sys.mjs r=webdriver-reviewers,jdescottes

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/446fca777d18