1958392 - The context menu for a downloaded file in the Downloads panel has too much inline padding

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Itiel]

Attachment: screenshot.png

This happens because the downloadsContextMenu menupopup lives under the <panel>, causing this to set the extra margin.
I think the ultimate solution would be to move downloadsContextMenu out of the panel, while making sure this isn't relevant anymore since then.

Otherwise it'd be possible to override the vars for this panel, but it feels like a gross hack...

Comment 1

[Itiel]

Tentatively marking bug 1954977 as the regressor, I have no idea if this came up recently but I figured it was too much of a coincidence that I found out about this just now.
I have no means of using mozregression on this machine so I can't be sure, but if it turns out this isn't the regressor feel free to remove the tag/keyword.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1954977

:emilio, since you are the author of the regressor, bug 1954977, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Alice0775 White]

Attachment: screenshot

Bug appears in ordinary menu popups as well as contextual menus.

Sorry this is Bug 1958396.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1958392 - Reset menuitem variables at the menupopup/panel boundaries. r=#theme

This is a more consistent with the other --panel-* variables.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ab1e94eb4a3
Reset menuitem variables at the menupopup/panel boundaries. r=desktop-theme-reviewers,dao

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2ab1e94eb4a3

Comment 7

[Bogdan Maris, Desktop Test Engineering]

Reproduced the issue from comment 0 using an old Nightly build from 2025-04-02. Verified that using latest Nightly 140.0a1 and Firefox Beta 139.0b1 on Windows 11 (and also checked Ubuntu 22.04 and MacOS 13) the extra padding is no longer seen in the download context menu.