1958438 - With ffvpx enabled, system freeze/crash/hang on scrolling through YT shorts for a long time

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Mayank Bansal]

Attachment: media.HTML

With ffvpx enabled, i was seeing some crashes/OOMs/system freezes. So i gave chatgpt some prompts which (i think) simulates that using a local VP9 file.
And I started getting crashes.

STR:

1. Set media.ffvpx-hw.enabled = TRUE if not already enabled.
2. download the VP9 big-buck-bunny video from here: https://test-videos.co.uk/vids/bigbuckbunny/webm/vp9/1080/Big_Buck_Bunny_1080_10s_30MB.webm
3. Open the attached testcase.
4. Browse to the VP9 video
5. Let the testcase run for 1-2 minutes.

AR: crash/OOM/system freeze
ER: Not so

https://crash-stats.mozilla.org/report/index/d3c96719-77c8-479d-9177-aaa870250404
https://crash-stats.mozilla.org/report/index/94df6704-5d42-4730-b3ea-e9f220250404

Repros with media.wmf.zero-copy-nv12-textures enabled/disabled.
Repros with gfx.direct3d11.reuse-decoder-device enabled/disabled.

---

The other thing i noticed was that while the testcase is running, (with ffvpx enabled) Microsoft Defender is running at continuous full speed (i.e. using 1 core 100% for the full time).

Comment 1

[Mayank Bansal]

Attachment: about:support

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1932772

Comment 3

[Mayank Bansal]

Here is a system-wide Samply profile

Comment 4

[Mayank Bansal]

GP+[GFX1-]: Error: 0x00000502, in /builds/worker/checkouts/gecko/gfx/angle/checkout/src/libANGLE/renderer/d3d/d3d11/ResourceManager11.cpp, rx::ResourceManager11::allocate:404. Internal D3D11 error: HRESULT: 0x887A0005 (removal reason: HRESULT: 0x887A0007): Error allocating Texture2D
(#5) Error Detect DeviceReset DeviceResetReason::RESET DeviceResetDetectPlace::WR_POST_UPDATE in GPU process
(#6) GP+[GFX1-]: [D3D11] 2 CreateTexture2D failure Size: Size(1920,1080)texture11: false Code: 0x887a0005
(#7) GP+[GFX1-]: Failed to make render context current during destroying.
(#8) GP+[GFX1-]: Failed to make render context current during destroying.
(#9) GP+[GFX1-]: Error in eglMakeCurrent: 0x300e
(#10) GP+[GFX1-]: Error in eglDestroySurface: 0x300e
(#11) Error CompositorBridgeChild receives IPC close with reason=AbnormalShutdown
(#12) CP+[GFX1-]: CompositorBridgeChild receives IPC close with reason=AbnormalShutdown
(#13) CP+[GFX1-]: CompositorBridgeChild receives IPC close with reason=AbnormalShutdown
(#14) CP+[GFX1-]: CompositorBridgeChild receives IPC close with reason=AbnormalShutdown
(#15) CP+[GFX1-]: CompositorBridgeChild receives IPC close with reason=AbnormalShutdown
(#16) CP+[GFX1-]: CompositorBridgeChild receives IPC close with reason=AbnormalShutdown
(#17) CP+[GFX1-]: CompositorBridgeChild receives IPC close with reason=AbnormalShutdown
(#18) CP+[GFX1-]: IPC Channel is already torn down unexpectedly
(#19) CP+[GFX1-]: IPC Channel is already torn down unexpectedly

Comment 5

[Mayank Bansal]

Attachment: gfx note error

Comment 6

[Mayank Bansal]

Fwiw, i have manually disabled ffvpx on my nightly profile due to this issue. There is a reproducible testcase here to help with diagnosis.

Comment 7

[Alastor Wu [:alwu]]

Thanks! I should be able to get back to this shortly—I've been tied up with other tasks recently. I'm hoping the fix for bug 1952340 will also address this issue.

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Here's a profile showing 9GB allocated and retained at d3d11va_frames_init: https://share.firefox.dev/40np7SB

Comment 9

[Alastor Wu [:alwu]]

Okay I finally found the leak, the memory is leaking due to this, an additional reference will be added via QueryInterface() everytime when creating an image, and those ref count would never be decreased.

Comment 10

[Alastor Wu [:alwu]]

Attachment: Bug 1958438 - Correctly manage the reference count of ID3D11Texture2D.

A successful QueryInterface call increments the reference count, and failure to
properly decrement it leads to memory leaks in the GPU process.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d3927f017ee9
https://hg.mozilla.org/integration/autoland/rev/72725b93e3b9
Correctly manage the reference count of ID3D11Texture2D. r=media-playback-reviewers,karlt

Comment 12

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/72725b93e3b9

Comment 13

[Alastor Wu [:alwu]]

Hi Mayank,
Would you mind helping me verify whether this issue is resolved on your end with the latest Nightly? Thanks!

Comment 14

[Mayank Bansal]

yes, this is fixed. I tested and it is working great. Forgot to update here.