1958457 - Update android nightly application-services version bump to new version 5853f8394635319577b8bd11ef5389637a39c420 from 2025-04-04 05:03:40

Status: RESOLVED FIXED

(Firefox for Android :: General, enhancement)

Description

[Update Bot]

This update covers 7 commits, including 1 new upstream commit I've never filed a bug on before. (It's the top one.). Here are the overall diff statistics, and then the commit information.

---

mobile/android/android-components/plugins/dependencies/src/main/java/ApplicationServices.kt | 2 +-
mobile/android/android-components/plugins/dependencies/src/main/java/moz.yaml | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

---

5853f8394635319577b8bd11ef5389637a39c420 by Ben Dean-Kawamura <[e-mail]>

https://github.com/mozilla/application-services/commit/5853f8394635319577b8bd11ef5389637a39c420
Authored: 2025-03-24 14:15:58 -0400
Committed: 2025-04-03 14:21:36 +0000

Update Suggest CLI code after the remote settings service changes

Files Modified:

• examples/suggest-cli/src/main.rs

---

4e8a52f74d1e3395954449791ba5fc08842a16d8 by Drew Willcoxon <[e-mail]>

https://github.com/mozilla/application-services/commit/4e8a52f74d1e3395954449791ba5fc08842a16d8
Authored: 2025-04-01 19:18:31 -0700
Committed: 2025-04-03 04:16:59 +0000

Bug 1957805 - Replace exposure suggestions with dynamic suggestions.

This replaces the exposure-suggestion type with a more general
dynamic-suggestion type. The key differences between the two are:

• Dynamic suggestions are intended to be shown to the user unlike exposure
  suggestions -- but they don't have to be
• They can have an arbitrary JSON payload
• They can have an opaque dismissal key so they can be dismissed
• They can have a non-default score

Dynamic suggestions can be used to do exposure suggestions, so they're a
superset basically.

Not sure if "dynamic" is a great name, I'm open to alternatives. I'm trying to
convey that they can carry arbitrary payloads and don't require code changes.

My motivation is that we have a bunch of new suggestion types planned, and I
don't want to have to keep making similar additions over and over. And more
generally I'd like to move offline Suggest more in the direction of an
Elasticsearch or generalized search engine that doesn't need to know every
detail about the suggestions it serves.

This PR keeps the keyword-matching strategy of exposure suggestions: exact
keyword matching, which should be sufficient for now. It's not hard to imagine
supporting different strategies in the future and letting each dynamic
suggestion type choose one (as we talked about for exposure suggestions,
e.g.: FTS, first word + prefix of remaining words, etc.) In the future I want to
explore more sophisticated query parsing and matching like a real search engine
would do (as we kind of talked about in the weather-suggestions PR).

Files Modified:

• components/suggest/src/db.rs
• components/suggest/src/lib.rs
• components/suggest/src/provider.rs
• components/suggest/src/query.rs
• components/suggest/src/rs.rs
• components/suggest/src/schema.rs
• components/suggest/src/store.rs
• components/suggest/src/suggestion.rs
• components/suggest/src/testing/mod.rs

---

d3826066ed69c86ae413b80ffa2dfe0c0a720f44 by Ben Dean-Kawamura <[e-mail]>

https://github.com/mozilla/application-services/commit/d3826066ed69c86ae413b80ffa2dfe0c0a720f44
Authored: 2025-03-26 12:49:46 -0400
Committed: 2025-04-02 22:35:29 +0000

Downgrade to UniFFI 0.29.0

0.29.1 is causing issues with moz-central, so let's go back to 0.29.0
for now.

Files Modified:

• Cargo.lock
• tools/uniffi-bindgen-library-mode/src/main.rs

---

d15375f68f2686be9be8548485c22f881b0e477e by Ben Dean-Kawamura <[e-mail]>

https://github.com/mozilla/application-services/commit/d15375f68f2686be9be8548485c22f881b0e477e
Authored: 2025-02-26 10:31:24 -0500
Committed: 2025-04-02 22:35:29 +0000

[DISCO-3243] Upgrade to UniFFI 0.29.1 and Glean 64.0.0

This mostly consisted of upgrading the custom types code and adding
[Remote] attributes. All-in-all, not too bad and I prefer the new
syntax.

Files Modified:

• Cargo.lock
• DEPENDENCIES.md
• components/as-ohttp-client/Cargo.toml
• components/autofill/Cargo.toml
• components/crashtest/Cargo.toml
• components/example/Cargo.toml
• components/fxa-client/Cargo.toml
• components/fxa-client/src/fxa_client.udl
• components/init_rust_components/Cargo.toml
• components/logins/Cargo.toml
• components/merino/Cargo.toml
• components/nimbus/Cargo.toml
• components/nimbus/src/nimbus.udl
• components/nimbus/src/stateful/nimbus_client.rs
• components/places/Cargo.toml
• components/places/src/ffi.rs
• components/places/src/places.udl
• components/push/Cargo.toml
• components/relevancy/Cargo.toml
• components/remote_settings/Cargo.toml
• components/remote_settings/src/client.rs
• components/search/Cargo.toml
• components/suggest/Cargo.toml
• components/support/error/Cargo.toml
• components/support/interrupt/Cargo.toml
• components/support/nimbus-fml/Cargo.toml
• components/support/nimbus-fml/src/client/mod.rs
• components/support/rust-log-forwarder/Cargo.toml
• components/support/rust-log-forwarder/src/rust_log_forwarder.udl
• components/sync15/Cargo.toml
• components/sync_manager/Cargo.toml
• components/sync_manager/src/syncmanager.udl
• components/tabs/Cargo.toml
• components/tabs/src/lib.rs
• components/tabs/src/tabs.udl
• components/webext-storage/Cargo.toml
• components/webext-storage/src/lib.rs
• megazords/full/DEPENDENCIES.md
• megazords/full/android/dependency-licenses.xml
• megazords/ios-rust/DEPENDENCIES.md
• megazords/ios-rust/focus/DEPENDENCIES.md
• tools/dependency_summary.py
• tools/embedded-uniffi-bindgen/Cargo.toml
• tools/uniffi-bindgen-library-mode/Cargo.toml
• tools/uniffi-bindgen-library-mode/src/main.rs

---

3aeb6f1802205eeca07e0751406d17e519dffb44 by Jan-Erik Rediger <[e-mail]>

https://github.com/mozilla/application-services/commit/3aeb6f1802205eeca07e0751406d17e519dffb44
Authored: 2025-03-18 15:31:31 +0100
Committed: 2025-04-02 22:35:29 +0000

Upgrade to JNA 5.17

Files Modified:

• CHANGELOG.md
• gradle/libs.versions.toml

---

b00541c804db251e35c8e3994d7496d73a8a2e48 by Jan-Erik Rediger <[e-mail]>

https://github.com/mozilla/application-services/commit/b00541c804db251e35c8e3994d7496d73a8a2e48
Authored: 2025-03-18 12:00:51 +0100
Committed: 2025-04-02 22:35:29 +0000

Update to Glean v64.0.0

Files Modified:

• CHANGELOG.md
• components/external/glean
• components/nimbus/android/src/test/java/org/mozilla/experiments/nimbus/NimbusTests.kt
• gradle/libs.versions.toml
• megazords/ios-rust/MozillaTestServices/MozillaTestServices.xcodeproj/project.pbxproj
• megazords/ios-rust/MozillaTestServices/MozillaTestServices.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved

---

3703c02b692ec61188c3a68a48e4f04bedf12458 by Ben Dean-Kawamura <[e-mail]>

https://github.com/mozilla/application-services/commit/3703c02b692ec61188c3a68a48e4f04bedf12458
Authored: 2025-04-02 09:55:30 -0400
Committed: 2025-04-02 19:53:16 +0000

Make AmpMatchingStrategyArg discriminents start at 1

This is the easiest way to land https://bugzilla.mozilla.org/show_bug.cgi?id=1924764.

The Desktop code for this currently assumes that discrimenents start at
one. That's how it's worked historically, but that behavior was never
correct. This allows us to fix the bug but not have to update the
suggest desktop code.

Files Modified:

• examples/suggest-cli/src/main.rs

---

Comment 2

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=608e50c2493d585926503ecb68d69135ecf30d03

Comment 3

[Update Bot]

Attachment: Bug 1958457 - Update android nightly application-services version bump to 5853f8394635319577b8bd11ef5389637a39c420

Comment 4

[Update Bot]

The try push is done, we found jobs with unclassified failures.

Needs Close Investigation:

• toolchain-linux64-android-gradle-dependencies - 1 of 1 failed (failed: P8jZ-HvNSnK1aRVctDJ96g)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor mobile/android/android-components/plugins/dependencies/src/main/java/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/361e6fa44886
Update android nightly application-services version bump to 5853f8394635319577b8bd11ef5389637a39c420 r=release-managers,RyanVM

Comment 6

[Update Bot]

This bug is being closed because a newer revision of the library is available.
This bug will be marked as a duplicate of it (because although this bug is older, it is superseded by the newer one).

Comment 7

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/361e6fa44886