1958523 - The custom Wallpaper already set does not persist after a browser restart or a browser update

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Alice Varro [avarro], Ecosystem QA]

[Affected versions]:

• Firefox Beta 138.0b2, Build ID: 20250402091540

[Affected Platforms]:

• Windows 10 x64
• macOS 14.5
• Ubuntu 22.04 LTS

[Prerequisites]:

• Have a new profile created and opened.
• Have set the “browser.newtabpage.activity-stream.newtabWallpapers.customWallpaper.enabled” pref set to true.

[Steps to reproduce]:

1. Open the browser from the prerequisites.
2. Open a new Tab and click the Personalize New Tab menu.
3. Click the “Upload an image” option and choose a wallpaper image.
4. Click the Done button.
5. Restart the browser (Cmd/Ctrl+Shift+J/ Cmd/Ctrl+option+R)
6. Observe the behavior on the New Tab.

[Expected result]:

• The custom Wallpaper previously set persists after a browser restart

[Actual result]:

• The custom Wallpaper already set does not persist after a browser restart.

[Notes]:

• The issue is not reproducible using the custom Color option.
• This issue is also reproducible when updating the browser to a higher version.
• A screen recording of the issue is attached here

Comment 1

[Nathan Barrett [:nbarrett]]

Attachment: Bug 1958523 - Fix custom wallpaper reset on restart r=#home-newtab-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1a476ddd245
Fix custom wallpaper reset on restart r=home-newtab-reviewers,maxx

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f1a476ddd245

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:nbarrett, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox138 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Alice Varro [avarro], Ecosystem QA]

I have verified this issue using Firefox Nightly 139.0a1, Build id: 20250415093646 an I can confirm that the issue is no longer reproducible on this version.

Comment 8

[Scott [:thecount] Downe]

Attachment: Bug 1958523 - Fix custom wallpaper reset on restart r=#home-newtab-reviewers

Original Revision: https://phabricator.services.mozilla.com/D245325

Comment 9

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Delay to release of custom wallpapers by 1 month
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Steps to test in bug
• Risk associated with taking this patch: Low
• Explanation of risk level: Just fixing a pref naming issue
• String changes made/needed: None
• Is Android affected?: no

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/f203d7de5eb2

Comment 11

[Alice Varro [avarro], Ecosystem QA]

I have verified this issue using Firefox Beta 138.0b8, Build ID: 20250416092013 using Windows 10 x64, macOS 14.5 and Ubuntu 24.04 LTS and I can confirm that the Custom wallpaper persists after the browser is restarted or updated to the next version.

Comment 12

[Amber Meryman]

I'm actually still seeing part of this issue in Firefox Beta 138.0b8

When I set a Custom wallpaper and then restart the browser, the wallpaper does NOT appear, but only for the first New Tab. All other subsequent New Tabs do have the wallpaper.

Comment 13

[Alice Varro [avarro], Ecosystem QA]

Hi Amber! Thanks for checking, this behavior could also be because of Bug 1953876, I'm seeing the custom wallpaper right after a restart but with a bit of delay because of the flickering situation. I guess it depends a lot on the internet connection or if the profile is a fresh one or it has a lot of tabs to load, I'll ask Max about this. Thank you!