195865 - Remove GLE support code

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[KENZ (Kenji Irie)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.3b) Gecko/20030227
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.3b) Gecko/20030227

Code to support GLE(GTK+ Layout Engine) is now not needed. Because GLE has
become a GTK module, and then it can be loaded and initialized at runtime.


Reproducible: Always

Steps to Reproduce:
1.
2.
3.




# and in fact, GLE with mozilla is useless with errors below:
# (Gtk-CRITICAL **: file gtkwidget.c: line 3931 (gtk_widget_get_toplevel):
assertion `GTK_IS_WIDGET (widget)' failed.

Comment 1

[KENZ (Kenji Irie)]

I think we can remove these now:
http://lxr.mozilla.org/seamonkey/search?string=MOZ_GLE

Comment 2

[KENZ (Kenji Irie)]

Attachment: patch for proposal

not tested yet

Comment 3

[KENZ (Kenji Irie)]

cc-ing blizzard,
blizzard: I've removed a part of gle support code at bug11847 patch. we should
remove the rest code too now, shouldn't we?

Comment 4

[KENZ (Kenji Irie)]

sorry, not bug 11847 but bug 118478.

Comment 5

[Christopher Blizzard (:blizzard)]

Yeah, no one uses it for anything.  If you want to whip up a patch, feel free.

Comment 6

[KENZ (Kenji Irie)]

Attachment: patch v2: Remove GLE support code

change:
 * appended autoconf-ed configure script by autoconf 2.13

Comment 7

[KENZ (Kenji Irie)]

cls:
This patch is backout of this check in (Add GLE support)
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=MozillaTinderboxAll&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Change+Size&hours=2&date=explicit&mindate=09%2F05%2F1999+08%3A50%3A00&maxdate=09%2F05%2F1999+08%3A55%3A00&cvsroot=%2Fcvsroot

I think this is harmless, but I can try this patch by building a build only on
my machine (Debian Linux(sid)). other platforms using configure/autoconf need
tested too?

Comment 8

[cls]

Comment on attachment 116442 [details] [diff] [review]
patch v2: Remove GLE support code

I have no problem with dropping GLE support but did GLE become a module for GTK
or GTK2?  

And a nit, when you make changes to configure.in, don't attach the configure
changes.  They're redundant and unnecessarily signficantly increase the size of
the patch.

r=cls

Comment 9

[KENZ (Kenji Irie)]

cls:
Thanks for your advice.
Oh, I found now that gle could be used not only as shared library (by linking
with, this need initializing code - gle_init) but also GTK+1 module(this doesn't
need gle_init) when the mozilla gle support code checked in (1999-09-05).

In fact, I googled about GLE a bit, so I didn't know it well.
BTW, GLE seems only for GTK+1, not GTK+2 (and now the development has stopped?).

Comment 10

[KENZ (Kenji Irie)]

Attachment: patch v2.1: patch for check-in (without configure diff)

Removed configure diff, there's no other changes.
I've forgotten saying thanks for your comment blizzard, thanks for your review
cls!

Comment 11

[KENZ (Kenji Irie)]

Please check in this someone?

Comment 12

[KENZ (Kenji Irie)]

I tried this patch, by building a fresh build without any configure options.
It works, yes of cource this pass the pre-checkin test.

Comment 13

[cls]

The patch has been checked in.

Comment 14

[KENZ (Kenji Irie)]

Thanks for your check-in on busyness Dauphin!