1958696 - Profiles menu back arrow has wrong color if there is only one profile

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect, P2)

Description

[Emilio Cobos Álvarez [:emilio]]

Attachment: image.png

See screenshot. This is because there's a fill: var(--appmenu-profiles-theme-fg), but that variable isn't set.

Comment 1

[Kestrel]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3ffd7e1d0343e9296c4cae88fcf7e7963268de67&tochange=0e88c22837b47a4a79e3329dde034196045cfb55

Regressed by Bug 1958196.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:jhirsch, since you are the author of the regressor, bug 1958196, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox138 (beta). However, the bug still isn't assigned.

:pluk, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 4

[Philip Luk [:pluk]]

Hi Jonathan.. can you please help take a look and work with the team on what the recommended next step should be?

Comment 5

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Per KimB this is not a blocker for 138 but we will prioritize it in the 139 cycle.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

This is a reminder regarding comment #3!

The bug is marked as tracked for firefox138 (beta). We have limited time to fix this, the soft freeze is in 9 days. However, the bug still isn't assigned.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1958196

Comment 8

[Cieara Meador [:cmkm] ⛔️ (away through EOY)]

Attachment: Bug 1958696 - Set a default value for profiles foreground color r?#profiles-reviewers

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Fx139 has one beta left this cycle before going to RC on Monday. Will this patch be ready for uplift before then?

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dde0adc3f53f
Set a default value for profiles foreground color r=profiles-reviewers,desktop-theme-reviewers,emilio,jhirsch

Comment 11

[amarc]

https://hg.mozilla.org/mozilla-central/rev/dde0adc3f53f

Comment 12

[Simona Badau, Desktop QA]

Reproduced the initial issue on Firefox 139.0a1 on macOS 15.

Verified as fixed using Firefox 140.0b2 and the latest Nightly 141.0a1 on macOS 15, Ubuntu 25.04 and Windows 11 - Profiles menu back arrow has now the correct color.