1958766 - Narrator reports the title of the document when moving by word or character out of a link

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[James Teh [:Jamie]]

Spun off bug 1950535 comment 6.

STR:

1. Ensure Firefox UIA is enabled: about:config, set accessibility.uia.enable to 2.
2. Turn on Narrator.
3. Open: https://example.com/
4. Press control+end to move to the last line of the document. Narrator should say: "More information"
5. Press control+leftArrow to move to the previous word.
   • Expected: Narrator should say: "permission"
   • Actual: Narrator says: "Example Domain"

I apparently regressed this in bug 1951573:

8:52.42 INFO: Last good revision: ea634003c48cb1ab307649baf8fb18476a0e14c6
8:52.42 INFO: First bad revision: 23a8b787c70c3a31c483006679653b2cdc13b300
8:52.42 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ea634003c48cb1ab307649baf8fb18476a0e14c6&tochange=23a8b787c70c3a31c483006679653b2cdc13b300

I think the problem is that setting the caret ends up setting the focus to the document, which is apparently problematic for Narrator. 😒 That said, I can't seem to reproduce that outside of Narrator just yet, which is weird.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1951573

Comment 2

[James Teh [:Jamie]]

[Removed accidental comment.]

Comment 3

[James Teh [:Jamie]]

Attachment: Bug 1958766: Don't change the focus when moving the caret with UIA.

In bug 1951573, I unified the code for setting the caret.
This includes focusing the node at the caret.
Unfortunately, Windows Narrator behaves badly if the focus is changed as a result of setting the caret.
Chromium doesn't move the focus if the caret is moved via UIA, even though it does for caret navigation like Firefox.
ATK in particular still wants the focus to be changed.
Therefore, add an aSetFocus argument to TextLeafRange::SetSelection so this can be configured by the caller.
Change UIA to specify aSetFocus = false.

Comment 4

[James Teh [:Jamie]]

https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=134576

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/196046a54600
https://hg.mozilla.org/integration/autoland/rev/759d9a59aa57
Don't change the focus when moving the caret with UIA. r=eeejay

Comment 6

[amarc]

https://hg.mozilla.org/mozilla-central/rev/759d9a59aa57

Comment 7

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2025-04-07 Firefox Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 142.0a1 and Firefox 141.0b2 on Windows 10 and Windows 11.