1958822 - The custom wallpaper message is not blocked after interacting with it

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: the message is not blocked after interacting.mp4

[Affected versions]:

• Firefox Beta 138.0b3 (Build ID: 20250404092111)
• Nightly 139.0a1 (Build ID: 20250404092926)

[Affected Platforms]:

• Windows 10 x64
• MacOS 14.7.1
• Ubuntu 24.04

[Prerequisites]:

• Have a Firefox Beta 138.0b2 en-US build installed/extracted.
• Have the following prefs set:
• browser.search.region = US
• nimbus.debug = true

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Navigate to the following link to force enroll in the experiment: about:studies?optin_slug=test-custom-wallpaper&optin_branch=control&optin_collection=nimbus-preview
3. Open a new tab.
4. Click the "Try it" button of the custom wallpaper message.
5. Change the system date to be 1 day in the future.
6. Open a new tab.

[Expected result]:

• The custom wallpaper message is no longer displayed.

[Actual result]:

• The custom wallpaper message is displayed.

[Notes]:

• Even if the message has the lifetime set to 2, after interacting with it, the message shold be blocked and no longer triggered.
• The issue is also reproducible if the "X" button of the message is clicked.
• The issue is also reproducible if the "Personalized New Tab" button is clicked while the message is displayed.
• Attached is a screenshot of the issue.

Comment 1

[Nathan Barrett [:nbarrett]]

Attachment: Bug 1958822 - Fixes for Newtab message various bugs r=#home-newtab-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/763cba6bd5e7
Fixes for Newtab message various bugs r=home-newtab-reviewers,amy

Comment 3

[Atila Butkovits]

Backed out for causing node failures.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/b71746decca9b86a1fc1d60c8895746a4d395502

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=763cba6bd5e7b11753ae3165d74fcca2bff9bd44

Failure log: https://treeherder.mozilla.org/logviewer?job_id=502853954&repo=autoland&lineNumber=297

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c749579cde3
Fixes for Newtab message various bugs r=home-newtab-reviewers,amy

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3c749579cde3

Comment 6

[Nathan Barrett [:nbarrett]]

Attachment: Bug 1958822 - Fixes for Newtab message various bugs r=#home-newtab-reviewers

Original Revision: https://phabricator.services.mozilla.com/D244643

Comment 7

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Telemetry for OMC messages on new tab will be incorrect
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Steps in patch
• Risk associated with taking this patch: low/none
• Explanation of risk level: user experience will remain the same
• String changes made/needed: no
• Is Android affected?: no

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/6cca961837d8

Comment 9

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 139.0a1 (Build ID: 20250409210623) and the latest Beta 138.0b6 (Build ID: 20250409230752) on Windows 10 x64, macOS 14.4.1 and Ubuntu 24.04 x64.

• The message is blocked when it's dismissed by clicking the "X" button or clicking the "Try it" button.
• The message is no longer triggered after 1 day has passed.