Closed
Bug 1959001
Opened 1 year ago
Closed 1 year ago
Remove unused onMessageViewMouseDown from cZ
Categories
(SeaMonkey :: Chat, task)
SeaMonkey
Chat
Tracking
(seamonkey2.53+ fixed)
RESOLVED
FIXED
Future
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.22)
Attachments
(1 file)
|
3.10 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
The function onMessageViewMouseDown returns early on there's no function called startScrolling so might as well remove it.
Whilst here might as well inline getEventCommand as the only caller is onMessageViewClick
Attachment #9477602 -
Flags: review?(frgrahl)
Attachment #9477602 -
Flags: approval-comm-release?
|
||
Comment 2•1 year ago
|
||
Comment on attachment 9477602 [details] [diff] [review]
1959001-irc-removeViewMouseDown-25322.patch
lgtm r/a+
Attachment #9477602 -
Flags: review?(frgrahl)
Attachment #9477602 -
Flags: review+
Attachment #9477602 -
Flags: approval-comm-release?
Attachment #9477602 -
Flags: approval-comm-release+
|
|
||
Updated•1 year ago
|
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/b9adb265d744
Remove unused onMessageViewMouseDown from cZ. r=frg DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
|
|
||
Comment 4•11 months ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/ae44b11c7eb0e41cad8a0bcd5f382ffc7dde931e
Remove unused onMessageViewMouseDown from cZ. r=frg a=frg
You need to log in
before you can comment on or make changes to this bug.
Description
•