1959006 - Inline getViewsContext into initViewsPopup in cZ

Status: RESOLVED FIXED

(SeaMonkey :: Chat, task)

Description

[Ian Neal]

The only caller of the function getViewsContext is initViewsPopup so we could inline it and do some tidying.

Comment 1

[Ian Neal]

Attachment: 1959006-irc-inlineViewContext-25322.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.21pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Ian Neal]

Attachment: 1959006-irc-inlineViewContext-v1_1-25322.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.21pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: 1 addition, 1 removal

Comment 3

[Ian Neal]

Attachment: 1959006-irc-inlineViewContext-v1_2-25322.patch

Fix missing string removal

Comment 4

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9478966 [details] [diff] [review]
1959006-irc-inlineViewContext-v1_2-25322.patch

LGTM r/a+

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c7af2c834748
Inline getViewsContext into initViewsPopup in cZ. r=frg DONTBUILD