Closed
Bug 1959007
Opened 6 months ago
Closed 4 months ago
Inline getFontContext into initFont functions in cZ
Categories
(SeaMonkey :: Chat, task)
SeaMonkey
Chat
Tracking
(seamonkey2.53? affected)
RESOLVED
FIXED
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.22)
Attachments
(1 file)
|
3.07 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
initFontFamilyPopup only makes use of the font family pref setting from getFontContext and initFontSizePopup only makes use of the font size pref setting and default font size from getFontContext so we should inline those parts and remove the rest.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.21pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Attachment #9477608 -
Flags: review?(frgrahl)
Attachment #9477608 -
Flags: approval-comm-release?
|
||
Updated•4 months ago
|
|
|
||
Comment 2•4 months ago
|
||
Comment on attachment 9477608 [details] [diff] [review]
1959007-irc-inlineFontContext-25322.patch
LGTM r/a+
Attachment #9477608 -
Flags: review?(frgrahl)
Attachment #9477608 -
Flags: review+
Attachment #9477608 -
Flags: approval-comm-release?
Attachment #9477608 -
Flags: approval-comm-release+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/77b458ebadda
Inline getFontContext into initFont functions in cZ. r=frg DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•