1959023 - Firefox menu bar changes and incorrect menu opens when window is inactive

Status: NEW

(Core :: Widget: Cocoa, defect, P3)

Description

[Sam Johnson]

Attachment: Screen recording

After bug 1941595, when using Firefox with multiple monitors on macOS, the Firefox menu bar options change when activating a window on another monitor. While this is annoying, it also causes undesirable behavior: When you try to open the Tools menu, the Profiles menu opens instead, because the Profiles option gets added when Firefox comes to the foreground.

Steps to reproduce:

1. Open Finder window on screen A.
2. Open Firefox window on screen B.
3. Note that when the Firefox window is active, the menu bar has a Profiles menu.
4. Click the Finder window to activate it. Notice that the Profiles menu disappears from the Firefox menu bar on screen B.
5. Attempt to open the Firefox tools menu (without first activating the Firefox window). Note that Profiles opens instead.

See attached screen recording demonstrating the issue.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1941595

:bradwerth, since you are the author of the regressor, bug 1941595, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Steven Michaud [:smichaud] (Retired)]

Bug 1941595 (whose fix caused this bug) was a regression caused by the fix for bug 1765391. The fix for bug 1765391 landed on the 135 branch. Could you test with FF 134 to see if this bug also happens there? You can download it here.

When you run FF 134, to keep it from automatically updating you'll need to set "Firefox Updates" to "Check for updates but let you choose to install them".

Comment 3

[Brad Werth [:bradwerth]]

I'll get to work on this.

Comment 4

[Brad Werth [:bradwerth]]

(In reply to Sam Johnson from comment #0)

Thank you for filing. I know that macOS Firefox has an issue where sometimes there is a "Profiles" menu and sometimes there is not, but I can't get your Steps to Reproduce to work for me. Please help me understand better, and maybe I will be able to reproduce.

Steps to reproduce:

1. Open Finder window on screen A.

The menubar is on screen A, yes?

2. Open Firefox window on screen B.

I am dragging a new Firefox window from screen A to screen B. Should I be doing something else?

3. Note that when the Firefox window is active, the menu bar has a Profiles menu.
4. Click the Finder window to activate it. Notice that the Profiles menu disappears from the Firefox menu bar on screen B.

Which screen has the Finder window? When I click on a Finder window (on either screen), I get the Finder menubar, as I should. There seems no possible way that clicking on a Finder window would leave me with the Firefox menubar. Also, the menubar is on screen A, not screen B, unless there's some other step I should be taking to get it on screen B.

5. Attempt to open the Firefox tools menu (without first activating the Firefox window). Note that Profiles opens instead.

Thanks. I know there is a real issue here, I just need to be able to reproduce the Bug properly so I can be sure my changes will fix it.

Comment 5

[Sam Johnson]

(In reply to Brad Werth [:bradwerth] from comment #4)

Hi! No problem:

The menubar is on screen A, yes?

Which screen has the Finder window? When I click on a Finder window (on either screen), I get the Finder menubar, as I should. There seems no possible way that clicking on a Finder window would leave me with the Firefox menubar. Also, the menubar is on screen A, not screen B, unless there's some other step I should be taking to get it on screen B.

There should be menu bars on every screen. You must enable "Displays have separate spaces" in System Settings > Desktop > Mission Control (which is enabled by default) for this to be the case. I'm guessing this is the source of the confusion.

I am dragging a new Firefox window from screen A to screen B. Should I be doing something else?

No dragging is required :)