1959024 - Menu spacing issues on macOS after bug 1958213

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Sam Johnson]

Attachment: Checked items with incorrect icon space.png

After bug 1958213, there are a few issues with rendering non-native menus on macOS:

1. Menu items with an icon no longer have the correct amount of padding between the icon and text.
2. Menu items that can be checked now incorrectly have space for an icon, even though they have no icon.
3. There is excessive padding on the right (even with accelerators present).

Attaching screenshots to demonstrate the issues.

Comment 1

[Sam Johnson]

Attachment: Checkable item with incorrect icon space.png

Comment 2

[Sam Johnson]

Attachment: Incorrect spacing after icon.png

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1958213

:emilio, since you are the author of the regressor, bug 1958213, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1959024 - Fix icon spacing on macOS. r=#theme

This was lost in the regressing bug. We should unify how we do this
across platforms (because right now it's a bit of a mess), but for now
just fix the regression.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83ebde21de5a
Fix icon spacing on macOS. r=sam

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures @ test_popup_attribute.xhtml

Backout link: https://hg.mozilla.org/integration/autoland/rev/c25d04a68ad925a428a52a6d4d76a2559eb3ef49

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup anchored bottomcenter topcenter x position - got 162, expected 161

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03cfff0d4fb5
Fix icon spacing on macOS. r=sam

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/03cfff0d4fb5

Comment 9

[Bogdan Maris, Desktop Test Engineering]

Reproduced the initial issue with the menu spacing using an old Nightly build from 2025-04-07. Verified that using the latest Nightly build 140.0a1 and Firefox 139.0b4 on MacOS 13.7 the affected menus don't have this issue anymore.