1959029 - Sidebar icon does not reflect sidebar position (left/right)

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect, P2)

Description

[Ina Popescu, Desktop QA]

Attachment: moving sidebar in Nightly 139.0a1.gif

Note

• The issue affects both the new sidebar and the legacy sidebar.
• To enable the new sidebar, go to about:preferences and check "Show sidebar"
• To enable the legacy sidebar, drag the sidebar button from the Customize page to the toolbar

Found in

• Nightly 139.0a1

Affected versions

• Nightly 139.0a1
• Firefox 138.0b4

Tested platforms

• Affected platforms: All

Steps to reproduce

1. Open Firefox and enable the new sidebar
2. Toggle the sidebar position (e.g., move it from left to right)
3. Observe the sidebar icon
4. Reset Defaults in the Customize page and repeat the steps for legacy sidebar

Expected result

• The sidebar icon should change to visually reflect the current position (left or right) of the sidebar.

Actual result

• The icon does not change and continues to look the same regardless of sidebar position.

Regression range

• N/A

Comment 1

[Gabriel Astorgano[:astor]]

Attachment: Bug 1959029 Sidebar Icon reflects sidebar position r=nsharpley

Comment 2

[Gabriel Astorgano[:astor]]

Tested the icon is the relevant options. Now the icon should reflect the sidebar position.

Added the changes to toolbarbutton-icons.css, trying to keep the code readable. The sidebar-button rules were already littered with stylelint rules, another lookup makes it messier.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cd333e01882b
https://hg.mozilla.org/integration/autoland/rev/d79fa65a2e4e
Sidebar Icon reflects sidebar position r=desktop-theme-reviewers,sfoster

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d79fa65a2e4e

Comment 5

[BugBot [:suhaib / :marco]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 6

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:gaastorgano, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox140 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Ina Popescu, Desktop QA]

I’ve tested this issue on the latest Nightly 141.0a1 across Windows 10, Ubuntu 22.04 and macOS 15. After enabling the new sidebar and toggling its position, the sidebar icon now updates correctly to reflect the current position (left or right). Marking this as Verified Fixed.