1959305 - When Parental Controls Service is disabled, DNS Over HTTPS settings fail to work with uncaught exception

Status: RESOLVED FIXED

(Core :: Networking: DNS, defect, P2)

Description

[Dan Ballard (Tor Browser Dev)]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0

Steps to reproduce:

• Built firefox with parental controls disabled (tor-browser, base-browser, mullvad-browser).
• navigated to settings / privacy and security
• changed the Enabled DNS over HTTPS to "Max Protection"

Actual results:

• observed the info pane above that it stayed as "learn more"
• observed error in terminal JavaScript error: chrome://browser/content/preferences/privacy.js, line 761: TypeError: lazy.gParentalControlsService is undefined

Expected results:

• info pane changes and shows as "Active" and lists a "provider"
• no error in console or browser terminal

Comment 1

[Dan Ballard (Tor Browser Dev)]

Attachment: Bug 1959305 - DoH pane undefined error in Privacy and Security when ParentalControlsServices disabled. r=#necko-reviewers,#settings-reviewers,tjr

From: Sarah Jamie Lewis <[e-mail]>
Date: Fri, 28 Feb 2025 09:30:45 -0800
Subject: [PATCH 1/1] DoH Settings: Check for nulll gParentalControlsService

When the parental controls service is disabled in a build, the DoH
settings now display the correct stauts when Increased or Max Protection
is enabled.

Previously, selecting either of these options would cause DoH to be
enabled, but the "Status" and "Provider" fields would not be properly
populated, due to a check on the gParentalControlsService causing an
error.

This check is now identical to the same check in DownloadIntegration.sys.mjs

Apply 1 suggestion(s) to 1 file(s)

Co-authored-by: ma1 <[e-mail]>

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Networking: DNS' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c6dff2dd98c
DoH pane undefined error in Privacy and Security when ParentalControlsServices disabled. r=settings-reviewers,Gijs

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7c6dff2dd98c