1959374 - Fix increased test failure after turning off browser.theme.native-theme

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Julian Gaibler]

The subtest helper_click_interrupt_animation.html of gfx/layers/apz/test/mochitest/test_group_zoom-2.html shows increased failure rates after landing bug 1955113.

Comment 1

[Julian Gaibler]

Attachment: Bug 1959374 - Fix increased test failure in helper_click_interrupt_animation.html

The subtest helper_click_interrupt_animation.html of gfx/layers/apz/test/mochitest/test_group_zoom-2.html shows increased failure rates after landing bug 1955113, which this patch attempts to address.

Comment 2

[Julian Gaibler]

Did a try run with this patch yesterday[1] that came back okay, since it's a test that fails intermittently, I started a second one[2] just to be sure.

[1] https://treeherder.mozilla.org/jobs?repo=try&revision=e9c25efb1324e3aade54cecdf9068c68e9bf2e6a
[2] https://treeherder.mozilla.org/jobs?repo=try&revision=0b95d151d2422bdcc1ee1b67ed538343f32c09c7

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b055aa60807
Fix increased test failure in helper_click_interrupt_animation.html r=botond

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/8b055aa60807

Comment 5

[Cosmin Sabou [:CosminS]]

Julian, this needs further attention as the failure rate looks unchanged, treeherder link.

Failure log looks to be the same: https://treeherder.mozilla.org/logviewer?job_id=503427662&repo=autoland

Comment 6

[Botond Ballo [:botond]]

I think it's clear that the issue is not with the browser UI style changes themselves, but rather there is an issue either in the test or in the scrolling implementation which those changes tickle.

As such, rather than backing out the style changes, I think it would make sense to disable the test on the affected platform (Mac) until the underlying issue can be investigated in more detail in bug 1959553.

I will post a patch to do this.

Comment 7

[Botond Ballo [:botond]]

Attachment: Bug 1959374 - Disable helper_click_interrupt_animation.html on Mac due to frequent intermittent failure. r=hiro

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Fwiw I did comment with this elsewhere, but the difference is that with those changes the browser chrome is one device pixel smaller, so it's not crazy

Comment 9

[Hiroyuki Ikezoe (:hiro)]

I checked screenshots taken at the time the test failed in the runs in comment 5. All of them are 1920x1080. On our CI there is another mac instance whose resolution is 4k, at least there was, so maybe this failure is not intermittent, it might be rather perma on 1920x1080 resolution macs.

Comment 10

[Botond Ballo [:botond]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #8)

Fwiw I did comment with this elsewhere, but the difference is that with those changes the browser chrome is one device pixel smaller, so it's not crazy

I figure that's a potentially legitimate consequence of the style changes. If it's unintended, then maybe there is additional investigation to do on the front-end side. The impact of a 1px browser chrome height change on this scrolling test is worth understanding/investigating either way.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9513d5a8195
Disable helper_click_interrupt_animation.html on Mac due to frequent intermittent failure. r=hiro

Comment 12

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/a9513d5a8195