1959379 - Implement #maybe-set-the-upcoming-non-traverse-api-method-tracker

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task)

Description

[Andreas Farre [:farre]]

#maybe-set-the-upcoming-non-traverse-api-method-tracker needs to be called for method trackers to operate successfully.

Comment 1

[Andreas Farre [:farre]]

Consider adding asserts that apiMethodTracker->mFinishedPromise is non-null.

Comment 2

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1959379 - Navigation API: Implement `#maybe-set-the-ongoing-non-traverse-api-method-tracker`. r=#dom-core,farre!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67f798582d85
Navigation API: Implement `#maybe-set-the-ongoing-non-traverse-api-method-tracker`. r=farre,dom-core

Comment 4

[Tom Schuster (MoCo)]

Please replace the uses of const JS::Value& with JS::Handle<JS::Value>. It's not clear to me if the former is safe here with the Promise creation happening in that function.

Comment 5

[Jan Jaeschke [:jjaschke]]

Filed Bug 1959971.

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/67f798582d85