Open Bug 1959530 Opened 7 months ago Updated 1 month ago

Remove lint-baseline.xml for each Android component

Categories

(Firefox for Android :: Tooling, task, P2)

All
Android
task

Tracking

()

ASSIGNED

People

(Reporter: jonalmeida, Assigned: jonalmeida)

References

Details

(Whiteboard: [fxdroid][code-health])

We added a lint-baseline.xml for every component in order to land bug 1872229, however the consequences are that every new component now needs to generate a baseline file and then add it to the tooling/rewriting/Generated.txt file as well. This increases the friction developers will feel for wanting to add a new component.

The lint failures are not that many, so I think it's best to just fix them immediately so that we can remove the baseline files.

Priority: P1 → P2

I haven't gotten to this yet. Matt, is this something you'd be interested in as part of your lint baseline work?

Flags: needinfo?(mtighe)

Thanks for the ping! This seems useful, I can add it to the code health backlog and forward it to the guild - perhaps someone there has capacity even though I don't currently. Without digging into the code, I'm wondering: will this affect new Gradle modules published in Fenix as well?

Flags: needinfo?(mtighe)
Whiteboard: [fxdroid][code-health]

Hey :jonalmeida, just didn't think to NI you last time but still curious to the answer of the question above.

Flags: needinfo?(jonalmeida942)

Yes, if we decided to take the path of adding gradle modules there, adding baseline files there will have to do the same thing we have for our existing gradle modules as well.

Flags: needinfo?(jonalmeida942)
You need to log in before you can comment on or make changes to this bug.