1959542 - Enable ToS by default for new users (Windows, Mac, Linux)

Status: VERIFIED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Chris Peterson [:cpeterson]]

We would like to enable the ToS feature flag by default in Firefox 138.x mid-cycle dot release on all desktop platforms (Mac, Linux, Windows installer, Windows MSIX), regardless of channel (Nightly, Beta, Release). We don't want to remove the ToS feature flag yet, in case we need it for some experiments. We just want to change the feature flag's default value.

Comment 1

[Chris Peterson [:cpeterson]]

We don't want to enable the ToS flag in the 138.0 major release, so we'll want to land in Nightly 139 but not uplift to 138 until Relman is accepting uplifts for the 138.x mid-cycle dot release.

Comment 2

[Meg Viar [:mviar]]

Attachment: Bug 1959542 - Enable ToS by default in Firefox 138.x mid-cycle dot release (Windows, Mac, Linux)

Comment 3

[Meg Viar [:mviar]]

Attachment: Bug 1959542 - Enable ToS by default in Firefox 138.x mid-cycle dot release (Windows, Mac, Linux)

Comment 5

[Meg Viar [:mviar]]

Attachment: Bug 1959542 - Enable ToS by default in Firefox 138.x mid-cycle dot release (Windows, Mac, Linux)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b19f01c4a432
Enable ToS by default in Firefox 138.x mid-cycle dot release (Windows, Mac, Linux) r=omc-reviewers,hanna_a

Comment 7

[Cristina Horotan [:chorotan]]

Backed out for causing bc failures

Backout link

Push with failures

Failure log

Comment 8

[Meg Viar [:mviar]]

Investigating the cause of the backout and will try to get a fix and uplift request in this week. Thanks for flagging, :chorotan.

Comment 9

[Meg Viar [:mviar]]

Attachment: Bug 1959542 - Enable ToS by default in Firefox (Windows, Mac, Linux)

Comment 10

[Meg Viar [:mviar]]

Attachment: Bug 1959542 - Enable ToS by default in Firefox 138.x mid-cycle dot release (Windows, Mac, Linux)

• Show ToS modal by default for all new users on official builds
  • Remove code related to the on-train rollout for Mac/Linus/MSIX

Original Revision: https://phabricator.services.mozilla.com/D247111

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c62c5b5629ff
Enable ToS by default in Firefox 138.x mid-cycle dot release (Windows, Mac, Linux) r=hanna_a,omc-reviewers

Comment 12

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_browserGlue_showModal_trigger.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/8eae95ea1da13b2b9bced84f96fae2b3736eaf1e

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/tests/browser/browser_browserGlue_showModal_trigger.js

TEST-PASS | browser/components/tests/browser/browser_browserGlue_showModal_trigger.js | The default browser prompt invocation waits for the user to be notified - true == true - 
[task 2025-04-29T23:55:12.237Z] 23:55:12     INFO - Buffered messages finished
[task 2025-04-29T23:55:12.237Z] 23:55:12     INFO - TEST-UNEXPECTED-FAIL | browser/components/tests/browser/browser_browserGlue_showModal_trigger.js | Uncaught exception in test bound show_preonboarding_modal - at resource://testing-common/sinon-7.2.7.js:167 - AssertError: expected showModal to have been called at least once but was never called
[task 2025-04-29T23:55:12.237Z] 23:55:12     INFO - Stack trace:
[task 2025-04-29T23:55:12.237Z] 23:55:12     INFO - fail@resource://testing-common/sinon-7.2.7.js:167:21
[task 2025-04-29T23:55:12.237Z] 23:55:12     INFO - failAssertion@resource://testing-common/sinon-7.2.7.js:126:16
[task 2025-04-29T23:55:12.237Z] 23:55:12     INFO - [2]</</mirrorPropAsAssertion/assert[name]@resource://testing-common/sinon-7.2.7.js:152:26
[task 2025-04-29T23:55:12.237Z] 23:55:12     INFO - show_preonboarding_modal@chrome://mochitests/content/browser/browser/components/tests/browser/browser_browserGlue_showModal_trigger.js:104:16
[task 2025-04-29T23:55:12.237Z] 23:55:12     INFO - async*handleTask@chrome://mochikit/content/browser-test.js:1170:26
[task 2025-04-29T23:55:12.237Z] 23:55:12     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1242:18
[task 2025-04-29T23:55:12.237Z] 23:55:12     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1383:14
[task 2025-04-29T23:55:12.237Z] 23:55:12     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1159:14
[task 2025-04-29T23:55:12.237Z] 23:55:12     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2025-04-29T23:55:12.237Z] 23:55:12     INFO - Leaving test bound show_preonboarding_modal
[task 2025-04-29T23:55:12.237Z] 23:55:12     INFO - Entering test bound can_disable_closing_via_esc
[task 2025-04-29T23:55:12.237Z] 23:55:12     INFO - Not taking screenshot here: see the one that was previously logged
[task 2025-04-29T23:55:12.238Z] 23:55:12     INFO - TEST-UNEXPECTED-FAIL | browser/components/tests/browser/browser_browserGlue_showModal_trigger.js | Uncaught exception in test bound can_disable_closing_via_esc - at resource://testing-common/sinon-7.2.7.js:3605 - TypeError: Attempted to wrap handleAction which is already wrapped
[task 2025-04-29T23:55:12.238Z] 23:55:12     INFO - Stack trace:
[task 2025-04-29T23:55:12.239Z] 23:55:12     INFO - checkWrappedMethod@resource://testing-common/sinon-7.2.7.js:3605:21
[task 2025-04-29T23:55:12.239Z] 23:55:12     INFO - wrapMethod@resource://testing-common/sinon-7.2.7.js:3653:31
[task 2025-04-29T23:55:12.239Z] 23:55:12     INFO - spy@resource://testing-common/sinon-7.2.7.js:2358:16
[task 2025-04-29T23:55:12.239Z] 23:55:12     INFO - spy@resource://testing-common/sinon-7.2.7.js:2083:26
[task 2025-04-29T23:55:12.239Z] 23:55:12     INFO - can_disable_closing_via_esc@chrome://mochitests/content/browser/browser/components/tests/browser/browser_browserGlue_showModal_trigger.js:137:26
[task 2025-04-29T23:55:12.239Z] 23:55:12     INFO - handleTask@chrome://mochikit/content/browser-test.js:1170:26
[task 2025-04-29T23:55:12.239Z] 23:55:12     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1242:18
[task 2025-04-29T23:55:12.239Z] 23:55:12     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1383:14
[task 2025-04-29T23:55:12.239Z] 23:55:12     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1159:14
[task 2025-04-29T23:55:12.240Z] 23:55:12     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2025-04-29T23:55:12.240Z] 23:55:12     INFO - 
[task 2025-04-29T23:55:12.240Z] 23:55:12     INFO - --------------
[task 2025-04-29T23:55:12.240Z] 23:55:12     INFO - wrapMethod@resource://testing-common/sinon-7.2.7.js:3679:26
[task 2025-04-29T23:55:12.240Z] 23:55:12     INFO - spy@resource://testing-common/sinon-7.2.7.js:2358:16
[task 2025-04-29T23:55:12.240Z] 23:55:12     INFO - spy@resource://testing-common/sinon-7.2.7.js:2083:26
[task 2025-04-29T23:55:12.240Z] 23:55:12     INFO - show_preonboarding_modal@chrome://mochitests/content/browser/browser/components/tests/browser/browser_browserGlue_showModal_trigger.js:100:26
[task 2025-04-29T23:55:12.240Z] 23:55:12     INFO - handleTask@chrome://mochikit/content/browser-test.js:1170:26
[task 2025-04-29T23:55:12.240Z] 23:55:12     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1242:18
[task 2025-04-29T23:55:12.240Z] 23:55:12     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1383:14
[task 2025-04-29T23:55:12.240Z] 23:55:12     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1159:14
[task 2025-04-29T23:55:12.240Z] 23:55:12     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2025-04-29T23:55:12.240Z] 23:55:12     INFO - Leaving test bound can_disable_closing_via_esc
[task 2025-04-29T23:55:12.241Z] 23:55:12     INFO - Console message: 1745970911993	Toolkit.Telemetry	TRACE	TelemetryReportingPolicy::shutdown

Comment 13

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Users will not receive the upfront notification of the terms of service and privacy policy and easy access to opt-outs upon starting Firefox for the first time
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: See test plan in https://phabricator.services.mozilla.com/D247111
• Risk associated with taking this patch: Low/Medium
• Explanation of risk level: This feature has already been tested in release for Windows users via Experimenter and Linux/Mac/MSIX Windows users at 1%. That said, wider exposure to the feature may draw additional feedback and potential criticism from users.
• String changes made/needed: No
• Is Android affected?: no

Comment 14

[Meg Viar [:mviar]]

I think I've resolved the issue, but running another try run of the failing job to be sure.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a2a12a961d9
Enable ToS by default in Firefox 138.x mid-cycle dot release (Windows, Mac, Linux) r=hanna_a,omc-reviewers

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/5dceb7d9b5ae

Comment 17

[amarc]

https://hg.mozilla.org/mozilla-central/rev/4a2a12a961d9

Comment 18

[Meg Viar [:mviar]]

Attachment: Bug 1959542 - Enable ToS by default in Firefox 138.x mid-cycle dot release (Windows, Mac, Linux)

• Show ToS modal by default for all new users on official builds
  • Remove code related to the on-train rollout for Mac/Linus/MSIX

Original Revision: https://phabricator.services.mozilla.com/D247111

Comment 19

[Chris Peterson [:cpeterson]]

For 138.0.3, next week's dot release, we want ToS to be enabled for the following percentages of new users:

• Windows = 100% Update: stay at 50%
• macOS = 25%
• Linux = 0%

For 139.0, next major release, we want ToS to be enabled for the following percentages of new users:

• Windows = 100%
• macOS = 100%
• Linux = 0%

Comment 20

[Chris Peterson [:cpeterson]]

No need to uplift to 138. 100% Windows will ride the trains with 139. Bug 1952000 increased macOS to 25% in 138.0.3: https://hg-edge.mozilla.org/releases/mozilla-release/rev/fbf6ce7772ba

Comment 21

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Beta 139.0b8 as well as our latest Nightly build 140.0a1 (2025-05-13)