Closed Bug 195959 Opened 22 years ago Closed 22 years ago

Drop causes image in -moz-user-select:all subtree to be duplicated

Categories

(Core :: DOM: Editor, defect, P3)

defect

Tracking

()

VERIFIED FIXED
mozilla1.4beta

People

(Reporter: kinmoz, Assigned: kinmoz)

References

Details

(Keywords: topembed+, Whiteboard: EDITORBASE+,edt_x3)

Attachments

(2 files)

This may be a non-issue if we start treating subtrees with -moz-user-select:all as single objects (bug 195957) but ... I noticed if I drag an image and drop it just before another image that is inside a -moz-user-select:all subtree, the image inside the subtree gets duplicated.
Whiteboard: EDITORBASE
Attached file Test Case
Re-assigning to Mike and nominating topembed since this is needed to complete the atomic selection feature delivered to one of our embedding clients.
Blocks: PhtN5
Keywords: topembed
(forgot the new assignee change)
Assignee: jfrancis → mjudge
Discussed in edt. Plussing.
Keywords: topembedtopembed+
Whiteboard: EDITORBASE → EDITORBASE+,edt_x3
Taking ... I have a fix for this.
Assignee: mjudge → kin
Priority: -- → P3
Target Milestone: --- → mozilla1.4beta
Attached patch Patch Rev 1Splinter Review
This patch prevents nsHTMLEditRules::CreateStyleForInsertText() from trying to split non-container nodes.
Attachment #119332 - Flags: superreview?(sfraser)
Attachment #119332 - Flags: review?(jfrancis)
Attachment #119332 - Flags: superreview?(sfraser) → superreview+
Comment on attachment 119332 [details] [diff] [review] Patch Rev 1 r=jfrancis
Attachment #119332 - Flags: review?(jfrancis) → review+
Fix checked into the TRUNK: mozilla/editor/libeditor/html/nsHTMLEditRules.cpp revision 1.281 Fix should appear in the 8am QA builds.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
with the attached test case, the subtree is no longer duplicated. vrfy'd fixed with 2003.04.10.
Status: RESOLVED → VERIFIED
OS: Windows 2000 → All
Hardware: PC → All
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: