1959688 - Entries in the DEFAULT section (prefs, environment) of Marionette manifests are ignored

Status: NEW

(Testing :: Marionette Client and Harness, defect, P3)

Description

[:Gijs (he/him)]

https://searchfox.org/mozilla-central/search?q=prefs+%3D&path=marionette**.toml&case=false&regexp=false

But from testing both Henrik and I don't see prefs actually applying, so AFAICT these are all no-ops.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We do not seem to support setting preferences that way. A quick look into the marionette harness brings up the following:

https://searchfox.org/mozilla-central/rev/601256c3cc6f397b018995810fd3f586570f50ee/testing/marionette/harness/marionette_harness/runner/base.py#1103-1147

There is no specific handling of extra settings beside which tests are active and which are not.

For the time being tests would have to set the pref on their own and if needed have to as well restart Firefox if the value is not mirrored.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Yep, can confirm - the two prefs in https://searchfox.org/mozilla-central/rev/601256c3cc6f397b018995810fd3f586570f50ee/browser/components/backup/tests/marionette/manifest.toml#3 are being set here, but can be safely removed. This is because one is being set to its default, and the other is being set in the test itself.

So these can be safely removed in the backup case.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As discussed with the team it would be good to see the current usage of prefs removed from our toml files given that those are not working.

At a later time we could consider adding support for this feature but for now it's not on our priority list.