1959694 - Shrink favicons database by removing favicon relations expired months ago

Status: RESOLVED FIXED

(Toolkit :: Places, task, P2)

Description

[Marco Bonardo [:mak]]

Many icon relations have not been updated in ages, I have like 20k relations in my database (corresponding to about 250 icons) that were not updated on their last visit and are older than 1 year.

In most cases they are urls that started redirecting or returning errors, or bogus favicons.

SELECT icon_url, page_url
FROM moz_icons_to_pages ip
JOIN moz_icons i ON i.id = icon_id
JOIN moz_pages_w_icons pi ON pi.id = page_id
JOIN moz_places ON url_hash = page_url_hash
WHERE ip.expire_ms < min((last_visit_date / 1000), (strftime('%s', 'now', 'localtime', 'start of day', '-1 year', 'utc') * 1000))
AND root = 0
AND foreign_count = 0

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1959694 - Shrink favicons database by removing favicon relations expired months ago. r=daisuke

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f0e0295fbc6a
https://hg.mozilla.org/integration/autoland/rev/a535ef8ca3c0
Shrink favicons database by removing favicon relations expired months ago. r=daisuke,places-reviewers

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a535ef8ca3c0