1959735 - Use WorkerCSPContext for EvalAllowed/WasmEvalAllowed queries

Status: RESOLVED FIXED

(Core :: DOM: Workers, task)

Description

[Tom Schuster]

We currently cache some CSP enforcement information like mEvalAllowed or mWasmEvalAllowed on the WorkerLoadInfo. It probably makes sense to add WorkerCSPContext::GetAllowsEval/GetAllowsWasmEval (similar to nsCSPContext::GetAllowsEval) instead.

Comment 1

[Tom Schuster]

Currently we have pretty bad test coverage of WorkerCSPContext because it's only used for one trusted type check, leading to mistakes like bug 1962090. I think the extended test coverage from using the WorkerCSPContext more broadly for eval should be enough justification for doing this work.

Comment 2

[Tom Schuster]

Attachment: Bug 1959735 - Use WorkerCSPContext for eval/wasm-eval queries. r?smaug

Comment 3

[Tom Schuster]

https://treeherder.mozilla.org/jobs?repo=try&revision=24123a7fd4e7646b73bf678c3359a2e7f28a9c1f

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8806de01bc76
Use WorkerCSPContext for eval/wasm-eval queries. r=smaug

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8806de01bc76