Closed Bug 1959970 Opened 4 months ago Closed 4 months ago

Merge code for unix and win in the NetAddrToPRNetAddr

Categories

(Core :: Networking: DNS, task)

task

Tracking

()

RESOLVED FIXED
139 Branch
Tracking Status
firefox139 --- fixed

People

(Reporter: anotherworldofworld, Assigned: anotherworldofworld)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:137.0) Gecko/20100101 Firefox/137.0

Steps to reproduce:

The support for the named pipes were added in the Bug 1288308. It introduced the same code in the NetAddrToPRNetAddr function for XP_UNIX and XP_WIN cases. That looks as leftover as in the one of the iteration the code for the windows had a check for a magic number instead of XP_WIN. Now both branches for XP_UNIX and XP_WIN are the same and could be merged into one.

The support for the named pipes were added in the Bug 1288308.
It introduced the same code in the NetAddrToPRNetAddr function for XP_UNIX and
XP_WIN cases. That looks as leftover as in the one of the iteration the code
for the windows had a check for a magic number instead of XP_WIN. Now both
branches for XP_UNIX and XP_WIN are the same and could be merged into one.

Assignee: nobody → anotherworldofworld
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Component: Untriaged → Networking: DNS
Product: Firefox → Core
Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/477ba5ca810a [netwerk] Merge code for unix and win in the NetAddrToPRNetAddr. r=necko-reviewers,sunil,valentin
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 139 Branch
Type: enhancement → task
QA Whiteboard: [qa-triage-done-c140/b139]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: