1960205 - Firefox Developer Edition APT Package .desktop File Has Wrong StartupWMClass

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[Allen George]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:138.0) Gecko/20100101 Firefox/138.0

Steps to reproduce:

• Install Firefox Developer Edition using the APT repository.
• Pin Firefox Developer Edition to the taskbar.
• Launch Firefox Developer Edition.

Actual results:

Firefox Developer Edition launches as a seperate program, not as a window of the pinned Firefox Developer Edition.

Expected results:

Firefox Developer Edition should launch as a program under the pinned shortcut.
(I think this is because the installed firefox-devedition.desktop file under /usr/share/applications declares the StartupWMClass as firefox-aurora, but the process/window is actually called firefox-dev. Changing the StartupWMClass to firefox-dev makes the launched window behave properly. Either the .desktop file or the process name shoud be changed to match the other.)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:bhearsum, could you have a look please?

For more information, please visit BugBot documentation.

Comment 5

[Shi [:Captune]]

Could we first find where the firefox-aurora is and confirm this issue?

Comment 6

[Julien Cristau [:jcristau]]

Attachment: Bug 1960205 - remove flatpak flavor from `mach repackage desktop-file` r=releng-reviewers,ahal

The flatpak repackaging code creates the desktop file directly, so we
don't need the subcommand anymore.

Comment 7

[Julien Cristau [:jcristau]]

Attachment: Bug 1960205 - remove deb-specific "DEPENDS" from shared get_build_variables r=releng-reviewers,ahal

Comment 8

[Julien Cristau [:jcristau]]

Attachment: Bug 1960205 - fix typo in deb repackaging comment r=releng-reviewers,ahal

Comment 9

[Julien Cristau [:jcristau]]

Attachment: Bug 1960205 - remove useless repackaging tests r=releng-reviewers,ahal

We were just asserting that the test expectation is wrong.

Comment 10

[Julien Cristau [:jcristau]]

Attachment: Bug 1960205 - add a TIMESTAMP to build variables (parsed from buildid) r=releng-reviewers,ahal

Use it to generate CHANGELOG_DATE for each package flavor, since deb and
rpm want different formats.

Comment 11

[Julien Cristau [:jcristau]]

Attachment: Bug 1960205 - remove application.ini data mangling from repackaging utils r=releng-reviewers,ahal

Let application_ini_data_from_{directory,tar} return metadata unchanged
from application.ini, and move mangling to get_build_variables.

Comment 12

[Julien Cristau [:jcristau]]

Attachment: Bug 1960205 - make sure desktop file's StartupWMClass matches the app's RemotingName r=releng-reviewers,ahal

This fixes DevEdition's StartupWMClass to match the actual application,
letting the window manager / desktop environment know to associate the
window with this desktop file.

Comment 13

[Julien Cristau [:jcristau]]

Attachment: Bug 1960205 - use shared code in flatpak repackaging r=releng-reviewers,ahal

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/28e1b1222c79
https://hg.mozilla.org/integration/autoland/rev/9127bc4b1a64
remove flatpak flavor from `mach repackage desktop-file` r=releng-reviewers,ahal
https://github.com/mozilla-firefox/firefox/commit/9054c7f7f70d
https://hg.mozilla.org/integration/autoland/rev/e974de15843c
remove deb-specific "DEPENDS" from shared get_build_variables r=releng-reviewers,ahal
https://github.com/mozilla-firefox/firefox/commit/31402dbe2de5
https://hg.mozilla.org/integration/autoland/rev/5f52967d23b9
fix typo in deb repackaging comment r=releng-reviewers,ahal
https://github.com/mozilla-firefox/firefox/commit/9c70fa3f2ee3
https://hg.mozilla.org/integration/autoland/rev/fc2fe8f5599e
remove useless repackaging tests r=releng-reviewers,ahal
https://github.com/mozilla-firefox/firefox/commit/8c622ff75668
https://hg.mozilla.org/integration/autoland/rev/c0bc3fb1c552
add a TIMESTAMP to build variables (parsed from buildid) r=releng-reviewers,ahal
https://github.com/mozilla-firefox/firefox/commit/3c50dbb7a391
https://hg.mozilla.org/integration/autoland/rev/ecb9d8874839
remove application.ini data mangling from repackaging utils r=releng-reviewers,ahal
https://github.com/mozilla-firefox/firefox/commit/f461cee31eb2
https://hg.mozilla.org/integration/autoland/rev/1d7180da707e
make sure desktop file's StartupWMClass matches the app's RemotingName r=releng-reviewers,ahal
https://github.com/mozilla-firefox/firefox/commit/b556f4a8b7a5
https://hg.mozilla.org/integration/autoland/rev/e6df6c9ac8df
use shared code in flatpak repackaging r=releng-reviewers,ahal

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8429133ca7c7
https://hg.mozilla.org/integration/autoland/rev/b2113af44b02
Revert "Bug 1960205 - use shared code in flatpak repackaging r=releng-reviewers,ahal" as requested by Julien.

Comment 16

[Atila Butkovits]

Backed out as requested.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/b2113af44b025788a4f130693e803de7883c6dc8

Also attaching a log link for the snap failures: https://treeherder.mozilla.org/logviewer?job_id=525215798&repo=autoland&task=Wg61WW5WS8qDeHh1GW-mSg.0

Comment 17

[Julien Cristau [:jcristau]]

Attachment: Bug 1960205 - don't pass the release_product parameter into repackaging commands. r?#releng

What we care about is the product being repackaged, i.e. the job's
shipping-product attribute, not release promotion's release_product
parameter, which is different and is not set outside of relpro.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5e10213384af
https://hg.mozilla.org/integration/autoland/rev/f59a85ba3d8f
remove flatpak flavor from `mach repackage desktop-file` r=releng-reviewers,ahal
https://github.com/mozilla-firefox/firefox/commit/4b6f5a086c70
https://hg.mozilla.org/integration/autoland/rev/6da7976407db
remove deb-specific "DEPENDS" from shared get_build_variables r=releng-reviewers,ahal
https://github.com/mozilla-firefox/firefox/commit/6150a8d62847
https://hg.mozilla.org/integration/autoland/rev/ce7a117eafca
fix typo in deb repackaging comment r=releng-reviewers,ahal
https://github.com/mozilla-firefox/firefox/commit/ae5aa72fa990
https://hg.mozilla.org/integration/autoland/rev/924ff12e8c0a
remove useless repackaging tests r=releng-reviewers,ahal
https://github.com/mozilla-firefox/firefox/commit/d18db687253b
https://hg.mozilla.org/integration/autoland/rev/3a24d29b1c73
add a TIMESTAMP to build variables (parsed from buildid) r=releng-reviewers,ahal
https://github.com/mozilla-firefox/firefox/commit/7eabec88a6cf
https://hg.mozilla.org/integration/autoland/rev/d088a956d648
remove application.ini data mangling from repackaging utils r=releng-reviewers,ahal
https://github.com/mozilla-firefox/firefox/commit/2cbfa955c2c3
https://hg.mozilla.org/integration/autoland/rev/c3c7c973b01f
make sure desktop file's StartupWMClass matches the app's RemotingName r=releng-reviewers,ahal
https://github.com/mozilla-firefox/firefox/commit/5318c1e65ab7
https://hg.mozilla.org/integration/autoland/rev/f01cf1bb9b32
use shared code in flatpak repackaging r=releng-reviewers,ahal
https://github.com/mozilla-firefox/firefox/commit/93a75581d70d
https://hg.mozilla.org/integration/autoland/rev/31744aa60c96
don't pass the release_product parameter into repackaging commands. r=releng-reviewers,taskgraph-reviewers,bhearsum

Comment 19

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f59a85ba3d8f
https://hg.mozilla.org/mozilla-central/rev/6da7976407db
https://hg.mozilla.org/mozilla-central/rev/ce7a117eafca
https://hg.mozilla.org/mozilla-central/rev/924ff12e8c0a
https://hg.mozilla.org/mozilla-central/rev/3a24d29b1c73
https://hg.mozilla.org/mozilla-central/rev/d088a956d648
https://hg.mozilla.org/mozilla-central/rev/c3c7c973b01f
https://hg.mozilla.org/mozilla-central/rev/f01cf1bb9b32
https://hg.mozilla.org/mozilla-central/rev/31744aa60c96