1960237 - Only offer "Add Search Engine" for forms with an explicit action attribute

Status: VERIFIED FIXED

(Firefox :: Search, defect, P3)

Description

[08xjcec48]

Steps to reproduce:

• Open https://lookup.icann.org/
• Right-click the form field and add a bookmark (Firefox 137) or search (Nightly) keyword
• Type keyword example.org into the address bar

Actual results:

It opens https://lookup.icann.org/ .

Expected results:

It should take you to a page with some information about example.org.

If this can't be done, Firefox shouldn't display the "Add keyword/search" option in the context menu.

Comment 1

[Chris Bellini (:cbellini)]

This would require an investigation to see if there are cases where forms without actions work as expected (unlike in this particular example).

Comment 2

[Moritz Beier [:mbeier]]

Attachment: Bug 1960237 - Only offer "Add Search Engine" for forms with an explicit action attribute. r?#search-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbc9aa438e43
Only offer "Add Search Engine" for forms with an explicit action attribute. r=search-reviewers,scunnane

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3de3f4140429
Revert "Bug 1960237 - for causing xpc failures @test_userEngine.js.

Comment 5

[agoloman]

Backed out for causing bc failures and xpc failures @test_userEngine.js.

• Backout link
• Push with failures
• Failure Log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b3c10c52a20
Only offer "Add Search Engine" for forms with an explicit action attribute. r=search-reviewers,scunnane

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81945da358ed
Revert "Bug 1960237 - Only offer "Add Search Engine" for forms with an explicit action attribute. r=search-reviewers,scunnane" for causing bc failures @ browser_search_userEngineDialog.js

Comment 8

[amarc]

Backed out for causing bc failures @ browser_search_userEngineDialog.js

• Backout link
• Push with failures
• Failure Log

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c860db50b945
Only offer "Add Search Engine" for forms with an explicit action attribute. r=search-reviewers,scunnane

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c860db50b945

Comment 11

[Dana Lucaci, Desktop QA]

This issue has been verified as fixed using Firefox 140.0a1 (20250513214736) on Windows 10, Ubuntu 22, and macOS 14.
Thank you!