Open Bug 1960260 Opened 10 months ago

Clean up body attrs arguments to addAccessibleTask

Categories

(Core :: Disability Access APIs, task)

task

Tracking

()

People

(Reporter: Jamie, Unassigned)

References

(Blocks 1 open bug)

Details

In accessibility browser tests, addAccessibleTask can currently take two arguments to specify attributes to add to body elements:

  • contentDocBodyAttrs: Attributes to add to the body of the top level document.
  • iframeDocBodyAttrs: Attributes to add to the body of the iframe document for iframe and remoteIframe tests.

The name contentDocBodyAttrs is unclear. Both documents are content documents. We should rename this to topDocBodyAttrs to make it explicit that this is for the top level document.

In addition, there's no way to specify attributes to be added to the test document, either top level or iframe depending on which test variant we're running. This is what we should use the name contentDocBodyAttrs for.

So, after this change, we should have:

  • contentDocBodyAttrs: Applies to the test document, regardless of whether it's top level, chrome, iframe or remote iframe.
  • topDocBodyAttrs: Attributes specifically for the top level (tab) document.
  • iframeDocBodyAttrs: Same as currently.

The challenge in making this change is that it involves figuring out the intent of each existing use of contentDocBodyAttrs and tweaking it accordingly.

You need to log in before you can comment on or make changes to this bug.