1960324 - [wpt-sync] Sync PR 51967 - Support non-simplifiable trigonometric functions

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 51967 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/51967
Details from upstream follow.

Daniil Sakhapov <[e-mail]> wrote:

Support non-simplifiable trigonometric functions

Fixed: 405140653
Change-Id: Ic65eaa3d0d38103f52173f2762fb3b9ae4658c0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6449971
Reviewed-by: Rune Lillesveen \<[e-mail]>
Commit-Queue: Daniil Sakhapov \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1446453}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=26e6acf60067deac24988b2debe2198866b1b46a

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 26 subtests

Status Summary

Firefox

OK : 2
PASS : 60
FAIL : 11

Chrome

CRASH: 2

Safari

OK : 2
PASS : 62
FAIL : 9

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-values/acos-asin-atan-atan2-computed.html [wpt.fyi]
  • calc(asin(sin(180deg * sibling-index()))) should be used-value-equivalent to 0deg: FAIL (Safari: FAIL)
  • calc(acos(cos(180deg * sibling-index()))) should be used-value-equivalent to 180deg: FAIL (Safari: FAIL)
  • calc(atan(tan(180deg * sibling-index()))) should be used-value-equivalent to 0deg: FAIL (Safari: FAIL)
  • atan2(1rem + 1px - 1px, -1rem) should be used-value-equivalent to 135deg: FAIL (Safari: PASS)
  • atan2(1vh + 0px, -1vh + 0px) should be used-value-equivalent to 135deg: FAIL (Safari: PASS)
• /css/css-values/sin-cos-tan-computed.html [wpt.fyi]
  • calc(sin(pi * sibling-index()) should be used-value-equivalent to 0: FAIL (Safari: FAIL)
  • calc(cos(pi * sibling-index()) should be used-value-equivalent to -1: FAIL (Safari: FAIL)
  • calc(tan(pi * sibling-index()) should be used-value-equivalent to 0: FAIL (Safari: FAIL)
  • calc(sin(180deg * sibling-index()) should be used-value-equivalent to 0: FAIL (Safari: FAIL)
  • calc(cos(180deg * sibling-index()) should be used-value-equivalent to -1: FAIL (Safari: FAIL)
  • calc(tan(180deg * sibling-index()) should be used-value-equivalent to 0: FAIL (Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0d5735591d2
[wpt PR 51967] - Support non-simplifiable trigonometric functions, a=testonly
https://hg.mozilla.org/integration/autoland/rev/15306a07fa8f
[wpt PR 51967] - Update wpt metadata, a=testonly

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d0d5735591d2
https://hg.mozilla.org/mozilla-central/rev/15306a07fa8f