1960409 - mozMessageBar.ftl is not pulled into about:translations in some contexts

Status: RESOLVED FIXED

(Firefox :: Translations, defect)

Description

[Erik Nordin [:nordzilla]]

Description

Bug 1815793 updated the about:translations page to use MozMessageBar.

Unfortunately, there are some contexts, such as in the test suite, where the mozMessageBar.ftl is not being pulled in.

This doesn't cause failures in the test, but it does produce an uncaught console error that I did not notice during initial code review.

---

Steps to Implement

This should be an easy fix by ensuring the .ftl file is present in the HTML:

--- a/toolkit/components/translations/content/translations.html
+++ b/toolkit/components/translations/content/translations.html
@@ -14,6 +14,7 @@
     <link rel="stylesheet" href="chrome://global/skin/in-content/common.css">
     <link rel="stylesheet" href="chrome://global/content/translations/translations.css">
     <link rel="localization" href="toolkit/branding/brandings.ftl"/>
+    <link rel="localization" href="toolkit/global/mozMessageBar.ftl"/>
     <link rel="localization" href="locales-preview/aboutTranslations.ftl"/>

Comment 1

[Erik Nordin [:nordzilla]]

Ricardo, are you interested in picking this up as a follow-up to Bug 1815793?

Should be a one-line change.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1815793

Comment 3

[Ricardo Delgado Gomez]

Attachment: Bug 1960409 - Add mozMessageBar.ftl localization link to about:translations. r?nordzilla!

Comment 4

[Ricardo Delgado Gomez]

Definitely! I added the change to a patch and checked both the live and test versions of about:translations. No more console warnings and the test version now properly displays the message bar text.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a5f2245a82e
Add mozMessageBar.ftl localization link to about:translations. r=nordzilla,translations-reviewers

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3a5f2245a82e