196073 - without a mail acct, Send menu items fail

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[sairuh (rarely reading bugmail)]

found using today's trunk comm builds on win2k and mac 10.2.4 (2003.03.05). if i
haven't created a mail account, the Send menu items from the browser fail.

1. don't create a mail (or news) account.
2. from the browser window, select any of the following menu items to invoke mail:

File - Send Link
File - Send Page
context menu - Send Page
context menu - Send Image

expected: a mail compose window should appear. soon thereafter, the mailnews
account wizard should appear.

actual results: nothing appears. (no js console output.)

Comment 1

[sairuh (rarely reading bugmail)]

using win2k builds, this regressed btwn the 2003.01.09.08 (works fine) and
2003.01.13.08 (broken) builds.

Comment 2

[(not reading, please use [e-mail] instead)]

accepting.  good catch.  I'll investigate.

Comment 3

[(not reading, please use [e-mail] instead)]

from the js console:

Cannot Send Page: [Exception... "Component returned failure code: 0x80004005 (NS
_ERROR_FAILURE) [nsIMsgComposeService.defaultIdentity]"  nsresult: "0x80004005 (
NS_ERROR_FAILURE)"  location: "JS frame :: chrome://messenger/content/mailNaviga
torOverlay.xul :: openComposeWindow :: line 40"  data: no]

Comment 4

[(not reading, please use [e-mail] instead)]

I'm the culprit.

"fix for #99363. from the browser window, send page, mailto urls, send link,
send image, ctrl m, new message should *all* use the default identity. a while back
we made the decision to make it use the currently selected account in the
3 pane, if the 3 pane was up. (see #79053) jglick and I have decided that was a
mistake and we are reverting."

I should have the fix in a minute...

Comment 5

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 6

[(not reading, please use [e-mail] instead)]

I'd want this on 1.3 final, too.

I'll ping drivers.

Comment 7

[(not reading, please use [e-mail] instead)]

fixed on the trunk, this has r/sr bienvenu.

if it goes on 1.3 branch, I'll update the target milestone.

Comment 8

[(not reading, please use [e-mail] instead)]

Comment on attachment 116335 [details] [diff] [review]
patch

this has r/sr bienvenu, over aim.

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 116335 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to the 1.3 branch.

Comment 10

[(not reading, please use [e-mail] instead)]

back ported to 1.3 final

Comment 11

[Ninoschka Baca]

Trunk build 2003-04-22: Mac 10.1.5
Trunk build 2003-04-24: WinXP, Linux RH 8
Verified Fixed, after checking the following scenarios:

File - Send Link
File - Send Page
context menu - Send Page
context menu - Send Image