Closed
Bug 1960753
Opened 1 year ago
Closed 8 months ago
Consider removing JS::EnqueueJob (and enqueueJob shell helper)
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
147 Branch
| Tracking | Status | |
|---|---|---|
| firefox147 | --- | fixed |
People
(Reporter: mgaudet, Assigned: rosansandanasamy, Mentored)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
I don't super love that we have the friend function js::EnqueueJob which enqueues a job on the job queue without any of the data that is normally used in our job queue.
It turns out this is relatively little used. the API turns out to exclusively be used by a shell helper, which in turn is only used in two tests. I think they can be rewritten to use regular promise things.
If so, we should just delete this code.
|
Reporter | |
Updated•1 year ago
|
Mentor: mgaudet
|
|
Reporter | |
Updated•1 year ago
|
|
||
Updated•8 months ago
|
Assignee: nobody → rosansandanasamy
Status: NEW → ASSIGNED
Pushed by arai_a@mac.com:
https://github.com/mozilla-firefox/firefox/commit/f3a8cf96dc99
https://hg.mozilla.org/integration/autoland/rev/0e9fe5cfc1df
Removed JS::EnqueueJob method and updated tests. r=arai
|
||
Comment 4•8 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
status-firefox147:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 147 Branch
|
||
Updated•7 months ago
|
QA Whiteboard: [qa-triage-done-c148/b147]
You need to log in
before you can comment on or make changes to this bug.
Description
•