1960900 - USB remains after address temporarily modified then reset

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Kestrel]

Attachment: Modifying address leaves behind USB after it is reset

STR:

1. Visit a site like https://mozilla.org.
2. Click in the address bar.
3. Modify the address.
4. Press Esc key several times to reset address.

Expected:
Unified Search Button (USB) disappears when address unmodified.

Actual:
USB remains visible for unmodified address, potentially confusing site identity (Bug 1928154) until page is reloaded.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c25d04a68ad925a428a52a6d4d76a2559eb3ef49&tochange=094882056dd4739c2799876a466680d0b8190494

Regressed by Bug 1957630.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:daisuke, since you are the author of the regressor, bug 1957630, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Thank you very much for your report, Kestrel!

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1960900: Not use isUnifiedSearchButtonAvailable upon reverting urlbar

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1957630

Comment 5

[Dianna Smith [:diannaS]]

:daleharvey do you think you can review this patch? Last week of betas is next week and would be good to land this during early beta so that it has some bake time.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75c313938c8e
Not use isUnifiedSearchButtonAvailable upon reverting urlbar r=daleharvey

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/75c313938c8e

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:daisuke, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox139 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Donal Meehan [:dmeehan]]

We are in the last week of beta for Fx139 with only 2 beta build left in the cycle.
:daisuke, could you please take a look at Comment 8?

Comment 10

[Daisuke Akatsuka (:daisuke)]

Thank you very much for the notice, Nonal!
I will do it.

Comment 11

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1960900: Not use isUnifiedSearchButtonAvailable upon reverting urlbar

Original Revision: https://phabricator.services.mozilla.com/D245850

Comment 12

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Unified Search Button still be shown even after address temporarily modified then reset
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: No
• Risk associated with taking this patch: Low
• Explanation of risk level: Very small patch and affects only for Unified Search Button
• String changes made/needed: None
• Is Android affected?: no

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/abcf477b2457

Comment 14

[Dana Lucaci, Desktop QA]

Reproduced the issue with Firefox 139.0a1 (2025-04-16) on macOS 14.
The issue is verified fixed with Firefox 140.0a1 (20250520213629) and Firefox 139.0b9 (20250516091640) on macOS 14, Windows 10 and Ubuntu 22.