196101 - group checks in sanitycheck should use ANSI-compliant SQL

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Dave Miller [:justdave]]

had to fix this for Sybase. :)

Patch coming

Comment 1

[Dave Miller [:justdave]]

Attachment: Patch

Comment 2

[Dave Miller [:justdave]]

Note that the ordering of the column names in the comparisons is really what's
important here (the leftmost column needs to be on the left side of the = in the
join comparison), and not changing them to use INNER JOIN, but using INNER JOIN
makes it easier to read as long as we're screwing with it.

Comment 3

[Bradley Baetz (:bbaetz)]

Comment on attachment 116346 [details] [diff] [review]
Patch

I'm OK with this.

However, what we really want, both here and in show_bug & friends, is to use a
MINUS query - ie:

<original query> where (assigned_to=<me> OR (param('useqacontact') and
qa_contact=<me>) OR reporter=<me> OR EXISTS (SELECT 1 FROM cc where
cc.bug_id=bugs.bug_id AND  cc.who=<me>) OR NOT EXISTS (SELECT group_id FROM
bug_group_map WHERE bug_group_map.bug_id=bugs.bug_id MINUS SELECT group_id FROM
user_group_map WHERE userid=<me>)

Or something along those lines.

It would be worth timing, at least.

It also has the advantage that we can just have a sub for that extra clause,
withoth having to poke arround like we used to do, or hard code it like we
currently do.

Comment 4

[Dave Miller [:justdave]]

Checking in sanitycheck.cgi;
/cvsroot/mozilla/webtools/bugzilla/sanitycheck.cgi,v  <--  sanitycheck.cgi
new revision: 1.64; previous revision: 1.63
done