196102 - Enable WSDL by default in mozilla

Status: RESOLVED FIXED

(Core :: XML, defect, P2)

Description

[harishd]

Currently WSDL can be used only if the environment variable MOZ_WSP is set and
extensions/interfaceinfo ( that WSDL depends on ) is built. To make
development/testing easier it would be a good thing to enable WSDL by default in
mozilla builds

Comment 1

[harishd]

Attachment: patch v1.0

With this patch WSDL will build by default in mozilla. I've added a flag
MOZ_DISABLE_WSDL for people who are not interested in building it. However, I
don't know how to disable building extensions/interfaceino. 

seawood?

Comment 2

[hacker formerly known as [e-mail]]

Comment on attachment 116347 [details] [diff] [review]
patch v1.0

Harish, you're going to need approval from someone on [e-mail] to
start buildling a new module by default.  Has the module been superreviewed? 

Use --enable-extensions=default,-interfaceinfo to disable the building of
interface info.  If since WDSL depends upon interface info, then
MOZ_DISABLE_WSP should be set whenever interfaceinfo isn't in MOZ_EXTENSIONS. 
Actually, can we avoid the double-negative ifdefs and leave that as MOZ_WSP.

Comment 3

[harishd]

>Harish, you're going to need approval from someone on [e-mail] to
>start buildling a new module by default.

Yes, it's has been approved by [e-mail].

>Actually, can we avoid the double-negative ifdefs and leave that as MOZ_WSP.

But then one has to set MOZ_WSP=1 manually no? 

Comment 4

[hacker formerly known as [e-mail]]

No.  You can have configure set MOZ_WSP=1 and call |AC_SUBST(MOZ_WSP)|.  Then
add |MOZ_WSP = @MOZ_WSP@| to config/autoconf.mk.in to expose that variable to
the rest of the core Mozilla makefiles.  With your current patch, you have to
set both the configure option & the env variable to disable the feature which
seems extreme.

Comment 5

[Daniel (Leaf) Nunes]

Attachment: check for --enable-extensions=interfaceinfo, set MOZ_WSP if found.

Comment 6

[Daniel (Leaf) Nunes]

Attachment: forgot allmakefiles.sh, cls corrected placement of AC_SUBST

Comment 7

[hacker formerly known as [e-mail]]

Comment on attachment 116569 [details] [diff] [review]
forgot allmakefiles.sh, cls corrected placement of AC_SUBST

r=cls

Comment 8

[harishd]

Btw, wsdl/proxy/interface code has been reviewed and superreviewed.

Comment 9

[harishd]

FYI: wsdl/proxy/interface code has been reviewed and superreviewed.

Comment 10

[harishd]

Attachment: patch v1.1

Changes to enable wsdl in mozilla:

This patch makes the flag MOZ_WSP obsolete. And since interfaceinfo has been
moved inside extensions/xmlextras I've changed the
Makefile.in/configure.in/configure/allmakefiles.sh to reflect that.

Comment 11

[harishd]

Attachment: patch v1.1

Comment 12

[Daniel (Leaf) Nunes]

Comment on attachment 117785 [details] [diff] [review]
patch v1.1

r=leaf (don't forget to remove the old file locations)

Comment 13

[harishd]

Forgot to mention:

The wsdl/proxy/interfaceinfo code was reviewed and super-reviewed by myself,
John Gaunt, Johnny Stenback, and David Bradley.

Comment 14

[Aleksey Nogin]

FYI: Brad Tbox is now whowing an extra "might be used uninitialized" warning
(see also bug 59652):

+extensions/xmlextras/wsdl/src/nsWSDLLoader.cpp:1381
+ `PRBool foundSOAPBinding' might be used uninitialized in this function

Comment 15

[harishd]

WSDL is now enabled!