Closed
Bug 1961069
Opened 1 year ago
Closed 1 year ago
Enable weather suggestions by default for all Suggest users
Categories
(Firefox :: Address Bar, task, P1)
Firefox
Address Bar
Tracking
()
VERIFIED
FIXED
139 Branch
People
(Reporter: adw, Assigned: daisuke)
References
Details
(Whiteboard: [sng])
Attachments
(2 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-beta+
|
Details | Review |
[Tracking Requested - why for this release]: Product wants to enable weather suggestions in the urlbar for 138.
Updated•1 year ago
|
| Assignee | ||
Comment 1•1 year ago
|
||
Updated•1 year ago
|
Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/79655ffc32c2
Enable weather suggestions by default r=adw
Comment 3•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox139:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 139 Branch
| Reporter | ||
Comment 4•1 year ago
|
||
Comment on attachment 9479540 [details]
Bug 1961069: Enable weather suggestions by default
Beta/Release Uplift Approval Request
- User impact if declined/Reason for urgency: Product leadership wants to enable weather suggestions by default in 138.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: When Suggest is enabled and the app's region is US, typing "weather" etc. in the urlbar should trigger a weather suggestion.
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): In terms of code, this patch only flips a pref from false to true, and we have thorough tests. In terms of UX, this will enable a new suggestion type in the urlbar for Suggest users when they type certain weather-related keywords.
- String changes made/needed: None
- Is Android affected?: No
Attachment #9479540 -
Flags: approval-mozilla-beta?
| Reporter | ||
Updated•1 year ago
|
Flags: qe-verify+
Updated•1 year ago
|
Comment 5•1 year ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D245831
Updated•1 year ago
|
Attachment #9479750 -
Flags: approval-mozilla-beta?
Updated•1 year ago
|
Attachment #9479540 -
Flags: approval-mozilla-beta?
Comment 6•1 year ago
|
||
beta Uplift Approval Request
- User impact if declined: Product leadership wants to enable weather suggestions by default in 138.
- Code covered by automated testing: yes
- Fix verified in Nightly: yes
- Needs manual QE test: yes
- Steps to reproduce for manual QE testing: When Suggest is enabled and the app's region is US, typing "weather" etc. in the urlbar should trigger a weather suggestion.
- Risk associated with taking this patch: Low
- Explanation of risk level: Low
- String changes made/needed: None
- Is Android affected?: no
Updated•1 year ago
|
Attachment #9479750 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•1 year ago
|
status-firefox138:
--- → fixed
Updated•1 year ago
|
QA Whiteboard: [qa-triaged]
Comment 8•1 year ago
|
||
I have verified this task on the latest Firefox Nightly 139.0a1 (Build ID: 20250421213526) and RC 138 (Build ID: 20250421163656) on Windows 11, macOS 15.3, and Ubuntu 24.04 x64.
- The
browser.urlbar.weather.featureGatepref is true by default. - The weather suggestion is triggered, displaying the simple UI if typing specific keywords or cities in the Address Bar (e.g. weather, forecast, air quality, new york, seattle, aus sunny, local radar lax, etc.)
Status: RESOLVED → VERIFIED
Flags: qe-verify+ → qe-verify-
Updated•1 year ago
|
Flags: qe-verify-
Updated•1 year ago
|
relnote-firefox:
--- → 138+
You need to log in
before you can comment on or make changes to this bug.
Description
•