1961115 - We don't completely suppress presenting snapshot/offscreen frames

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Description

[Nicolas Silva [:nical]]

Moving the patches from bug 1959648 here to split the WebRender and displaylist work and land what's already landable.

WebRender currently correctly skips compositing frames that don't have the present flag set, but we still run some widget/compositor code that we should not, including swapping buffers and that's not good.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1961115 - Pass new_frame_ready parameters via a struct. r=#gfx-reviewers

This patch is a preliminary refactoring to make it simpler to pass additional information to the C++ side and should not affect behavior.
In a followup patch the widget glue will have special handling for frames that need to be rendered but not presented.

Comment 2

[Nicolas Silva [:nical]]

Attachment: Bug 1961115 - Skip compositor-related work when rendering without presenting. r=#gfx-reviewers

Comment 3

[Nicolas Silva [:nical]]

Attachment: Bug 1961115 - Avoid scheduling an extra frame when a transaction is rendered immediately. r=#gfx-reviewers

In addition, rename NotifyDidSceneBuild into ScheduleFrameAfterSceneBuild. Right now it is only used for that purpose but it would cause issues if we start relying on it to be called after all scene builds since with this patch we won't call it if we do not need a new frame.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12836f4f3c36
Pass new_frame_ready parameters via a struct. r=gfx-reviewers,gw
https://hg.mozilla.org/integration/autoland/rev/9f795cb0c6ae
Skip compositor-related work when rendering without presenting. r=gfx-reviewers,gw
https://hg.mozilla.org/integration/autoland/rev/272e5fda747a
Avoid scheduling an extra frame when a transaction is rendered immediately. r=gfx-reviewers,lsalzman

Comment 5

[Cosmin Sabou [:CosminS]]

Backed out 3 changesets (Bug 1961115) for causing build bustages.

Push with failures

Failure log

Backout link

Comment 6

[Nicolas Silva [:nical]]

Attachment: WIP: Bug 1961115 - Fix webrender example build.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9099f91a9ce6
Pass new_frame_ready parameters via a struct. r=gfx-reviewers,gw
https://hg.mozilla.org/integration/autoland/rev/65568cbb4e4b
Skip compositor-related work when rendering without presenting. r=gfx-reviewers,gw
https://hg.mozilla.org/integration/autoland/rev/9def00d6fd0f
Avoid scheduling an extra frame when a transaction is rendered immediately. r=gfx-reviewers,lsalzman

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/9099f91a9ce6
https://hg.mozilla.org/mozilla-central/rev/65568cbb4e4b
https://hg.mozilla.org/mozilla-central/rev/9def00d6fd0f