1961206 - Separate out default search engine identifier telemetry probe into multiple probes

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Mark Banner (:standard8)]

The current search.engine.default.engine_id and search.engine.private.engine_id fields actually contain multiple pieces of information:

• The identifier of the application provided engine
• An indication (telemetry suffix) of partner code associated with the engine.
• If the application provided engine has been allowed to be overridden by a third party engine.
• The name of the engine if it is not an application provided engine (via other-<enginename>.

This makes analysis harder as it requires breaking down of the string into its different parts. We already have search.engine.default.display_name (and the private equivalent). So we should only need new probes for the first two.

The old probe will be retained for now, to reflect legacy telemetry, and to allow time for overlap between the old probes and new.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1961206 - Rework SearchService.getEngineInfo and interfaces to work better with TypeScript. r?scunnane!

This also simplifies the return type, so that it is easier to work with.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1961206 - Separate out default search engine telemetry reporting into multiple single-purpose fields. r?scunnane!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22c4d663a615
Rework SearchService.getEngineInfo and interfaces to work better with TypeScript. r=scunnane,search-reviewers
https://hg.mozilla.org/integration/autoland/rev/13415e4bdb8a
Separate out default search engine telemetry reporting into multiple single-purpose fields. r=scunnane,search-reviewers

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/22c4d663a615
https://hg.mozilla.org/mozilla-central/rev/13415e4bdb8a