Closed
Bug 196130
Opened 21 years ago
Closed 21 years ago
Make GetRequestURL from nsHTMLFormElement accessable
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: pavlov, Assigned: pavlov)
Details
Attachments
(1 file)
7.10 KB,
patch
|
john
:
review+
bryner
:
superreview+
|
Details | Diff | Splinter Review |
This patch just adds GetRequestURL to nsIForm and makes nsHTMLFormElement implement it using the version that is already in the file. I moved the function down below ForgetPendingSubmission in nsHTMLFormElement so that it was in the same spot as in the header, but there were no code changes aside from adding the API and making the function use NS_IMETHOD*
Assignee | ||
Comment 1•21 years ago
|
||
Assignee | ||
Updated•21 years ago
|
Attachment #116391 -
Flags: superreview?(bryner)
Attachment #116391 -
Flags: review?(jkeiser)
Comment 2•21 years ago
|
||
Comment on attachment 116391 [details] [diff] [review] make the api public > + * @param aActionURL the full, unadulterated URL you'll be submitting to It's a @return, not an @param, no?
Assignee | ||
Comment 3•21 years ago
|
||
Comment on attachment 116391 [details] [diff] [review] make the api public I consider something that you return a return. Not an out param.
Comment 4•21 years ago
|
||
Comment on attachment 116391 [details] [diff] [review] make the api public sr=bryner if jkeiser approves of making this API public.
Attachment #116391 -
Flags: superreview?(bryner) → superreview+
Comment 5•21 years ago
|
||
Comment on attachment 116391 [details] [diff] [review] make the api public Yeah, it's all right with me. It's not called all that much.
Attachment #116391 -
Flags: review?(jkeiser) → review+
Comment 6•21 years ago
|
||
Oh, stuart, optionally if you could put the text [OUT] at the end of the @param comment I'd be obliged. I forgot to do that before.
Assignee | ||
Comment 7•21 years ago
|
||
checked in. I added the [OUT] as you requested.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: HTML: Form Submission → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•