1961308 - Crash in [@ suggest::db::SuggestDao::fetch_yelp_suggestions]

Status: RESOLVED FIXED

(Application Services :: Suggest, defect, P1)

Description

[Andrew McCreight [:mccr8]]

Crash report: https://crash-stats.mozilla.org/report/index/307d98db-8174-43ea-a2bc-873a60250417

MOZ_CRASH Reason:

range start index 3 out of range for slice of length 1

Top 10 frames:

0  xul.dll  MOZ_Crash(char const*, int, char const*)  mfbt/Assertions.h:381
0  xul.dll  RustMozCrash(char const*, int, char const*)  mozglue/static/rust/wrappers.cpp:18
1  xul.dll  mozglue_static::panic_hook(std::panic::PanicHookInfo*)  mozglue/static/rust/lib.rs:99
2  xul.dll  core::ops::function::Fn::call<void (*)(ref$<std::panic::PanicHookInfo>), tupl...  /rustc/05f9846f893b09a1be1fc8560e33fc3c815cfecb/library/core/src/ops/function.rs:250
3  xul.dll  alloc::boxed::impl$30::call()  library/alloc/src/boxed.rs:1990
3  xul.dll  std::panicking::rust_panic_with_hook()  library/std/src/panicking.rs:839
4  xul.dll  std::panicking::begin_panic_handler::closure$0()  library/std/src/panicking.rs:704
5  xul.dll  std::sys::backtrace::__rust_end_short_backtrace<std::panicking::begin_panic_h...  library/std/src/sys/backtrace.rs:168
6  xul.dll  std::panicking::begin_panic_handler()  library/std/src/panicking.rs:695
7  xul.dll  core::panicking::panic_fmt()  library/core/src/panicking.rs:75

Also showing up as [@ <core::ops::range::RangeFrom<usize> as core::slice::index::SliceIndex<[T]>>::index ]
bp-56b4b577-9866-45fd-9f9c-432620250417

I hit this myself right after I started the browser and was doing something, but I don't remember what.

Comment 1

[Andrew McCreight [:mccr8]]

Crash volume looks very high, and the build has probably only just rolled out. We might want to back out the regressor.

Comment 2

[Simeon Vincent [:dotproto]]

This is affecting me on macOS 15.1 (24B83). I just updated Nightly to 139.0a1 (2025-04-17) (aarch64) (Build ID 20250417163004). Every time I focus the address bar and type a set of characters (e.g. "vi" or "vo") Firefox will crash after I enter the second character. Related crash report: https://crash-stats.mozilla.org/report/index/e9b10b25-38d3-4914-af84-7f4250250418

Comment 3

[Drew Willcoxon :adw]

Sorry about this, if you set browser.urlbar.suggest.yelp = false that should fix it for you. We'll need to back out the bad commits on application-services and then do a vendor.

Comment 4

[Mark]

Problem occurred just after upgrading, happened when I had typed three characters in the search bar, specifically ama and then the browser crashed instead of displaying amazon.com. This happened twice (crashes bp-e87dc114-ac48-4116-b643-142600250418 and bp-419a3e8e-1784-4771-9d52-fc2f80250418). Then I told it to not restart Firefox after the second crash, ran Speedy Fox, and started it up, and then I was able to type in ama and was able to select https://www.amazon.com.

Comment 5

[Drew Willcoxon :adw]

We've disabled Yelp suggestions via remote settings on Nightly (and Beta), so this should be fixed now, although it may take some time for a given client to see the changes.

The problematic code was added to application-services in these bugs, we're not sure which yet:

• bug 1957309
• bug 1953666
• bug 1953667

And then that code was vendored into m-c in bug 1961039.

We've started backing out the PRs in app-services and we'll do another vendor when that's done so that this doesn't make its way to Beta or Release. That will give us time to address the problem.

Comment 6

[Drew Willcoxon :adw]

Bug 1961338 has landed, so this is now fixed in m-c.