1961452 - Don't call SessionAccessibility.NativeProvider.setAttached until native handle is set

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[Makoto Kato [:m_kato] (fever, slow response)]

This issue is a possible crash case.

Actually SessionAccessibility.NativeProvider.setAttached is called in C++ constructor of SessionAccessibility. But native handle is set after calling the constructor. So when NativeProvider.setAttached is called, C++ side might not set native handle yet.

So we should not call setAttached in the constructor.

Comment 1

[Makoto Kato [:m_kato] (fever, slow response)]

Attachment: Bug 1961452 - Don't call SetAttached until native handle is set. r=#geckoview-reviewers!

This issue is a possible crash case.

Actually SessionAccessibility.NativeProvider.setAttached is called in
C++ constructor of SessionAccessibility. But native handle is set
after calling the constructor. So when NativeProvider.setAttached is
called, C++ side might not set native handle yet.

So we should not call setAttached in the constructor.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d04265df5fbe
Don't call SetAttached until native handle is set. r=geckoview-reviewers,ohall

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d04265df5fbe

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:m_kato, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox138 to wontfix.

For more information, please visit BugBot documentation.

Comment 5

[Makoto Kato [:m_kato] (fever, slow response)]

bp-ab7644f8-2186-40e5-b8f5-e63780250428 is exactly this situation